Flatten _doJoin
#1760
Merged
Flatten _doJoin
#1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
added
the
do not merge
TomAFrench
force-pushed
the
flatten-do-join
branch
from
5eabb15 to
4dfbc06
Compare
TomAFrench
removed
the
do not merge
nventuro
approved these changes
Sep 14, 2022
TomAFrench
added a commit
that referenced
this pull request
Sep 15, 2022
* master: Add `ManagedPoolSwapFees` contract (#1755) Pull _poolState up into ManagedPool (#1774) Adding Foundry support (#1771) Cache token weight in _onSwapGivenIn/Out (#1769) Fix deployments package (#1773) Avoid double zero duration check in `calculateValueChangeProgress` (#1772) Extend PoolRegLib (#1770) refactor: flatten _doJoin (#1760) Removing return values from VaultActions. (#1765)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on #1759
This PR inlines the ManagedPool specific code (LP allowlist and swaps toggle) with the dispatch code.