Automatically renormalize on gradual weight changes #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Sep 14, 2022
| @@ -1057,7 +1062,7 @@ contract ManagedPool is BaseWeightedPool, ProtocolFeeCache, ReentrancyGuard, ICo | |||
| _tokenState[token], | |||
| startWeights[i], | |||
| endWeight, | |||
| denormWeightSum | |||
| FixedPoint.ONE | |||
There was a problem hiding this comment.
Hm, interesting. This does seem correct. It'd be good to review the existing tests to get a sense of what the current coverage of all of this looks like.
|
One thing I like about this is that we don't need to pass in a |
nventuro
approved these changes
Sep 15, 2022
TomAFrench
force-pushed
the
renormalize-weights-on-weight-change
branch
from
105bfda to
ccf99f7
Compare
TomAFrench
force-pushed
the
renormalize-weights-on-weight-change
branch
from
ccf99f7 to
ccad8fe
Compare
TomAFrench
added a commit
that referenced
this pull request
Sep 16, 2022
* master: Add some random fuzz tests (#1782) docs: typos and readability (#1784) refactor: rename WeightCompression to ValueCompression (#1783) Update `_startGradualWeightChange` to return updated pool state (#1779) feat: automatically renormalize weight sum on gradual weight change (#1768) Inline `getSwapEnabled()` inside swap hooks (#1778) refactor: remove unused constants (#1781) style: rearrange functions (#1777)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the issue we identified a while back where a Pool owner can manipulate
_denormWeightSumby manipulating the weights in combination with adding or removing tokens