Composable stable pool versioning #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
approved these changes
Nov 23, 2022
added 2 commits
November 23, 2022 09:52
nventuro
deleted the
composable-stable-pool-deployment-base-versioning
branch
jubeira
pushed a commit
that referenced
this pull request
Nov 24, 2022
* WIP: version for ComposableStablePool. * Fix stack too deep error and adjust tests. * ComposableStablePoolFactory test. * Remove unused var. * Add factory version / pool version. * Fix benchmarks. * Remove IVersionProvider.
TomAFrench
pushed a commit
that referenced
this pull request
Nov 24, 2022
* WIP: version for ComposableStablePool. * Fix stack too deep error and adjust tests. * ComposableStablePoolFactory test. * Remove unused var. * Add factory version / pool version. * Fix benchmarks. * Remove IVersionProvider.
TomAFrench
pushed a commit
that referenced
this pull request
Nov 24, 2022
* WIP: version for ComposableStablePool. * Fix stack too deep error and adjust tests. * ComposableStablePoolFactory test. * Remove unused var. * Add factory version / pool version. * Fix benchmarks. * Remove IVersionProvider.
TomAFrench
pushed a commit
that referenced
this pull request
Nov 24, 2022
* WIP: version for ComposableStablePool. * Fix stack too deep error and adjust tests. * ComposableStablePoolFactory test. * Remove unused var. * Add factory version / pool version. * Fix benchmarks. * Remove IVersionProvider.
TomAFrench
pushed a commit
that referenced
this pull request
Nov 25, 2022
* WIP: version for ComposableStablePool. * Fix stack too deep error and adjust tests. * ComposableStablePoolFactory test. * Remove unused var. * Add factory version / pool version. * Fix benchmarks. * Remove IVersionProvider.
TomAFrench
pushed a commit
that referenced
this pull request
Nov 25, 2022
* WIP: version for ComposableStablePool. * Fix stack too deep error and adjust tests. * ComposableStablePoolFactory test. * Remove unused var. * Add factory version / pool version. * Fix benchmarks. * Remove IVersionProvider.
nventuro
added a commit
that referenced
this pull request
Nov 30, 2022
* Prevent invariant overflow (#1690) * Add check to prevent invariant overflow * Update pkg/pool-stable/contracts/ComposableStablePoolProtocolFees.sol Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> * Composable stable pool versioning (#2034) * WIP: version for ComposableStablePool. * Fix stack too deep error and adjust tests. * ComposableStablePoolFactory test. * Remove unused var. * Add factory version / pool version. * Fix benchmarks. * Remove IVersionProvider. * feat: add proportional joins/exits * Deployment preparation: Composable stable pool v2 (#2028) * feat: add proportional joins/exits to ComposableStablePool * deprecate 20220906-composable-stable-pool task * add new task * add artifacts * checkpoint * refactor: finish fork test * refactor: remove weighted encoder name change (extraneous for this deployment) * feat: add deprecations section to stable pool, and update deployments readme * fix: deprecated paths * Update README.md Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> * fix: re-add _computeProportionalAmountsOut * test: update test to remove use of deprecated function Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: Juan Ignacio Ubeira <juani@balancer.finance>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an version getter for
ComposableStablePoolandComposableStablePoolFactory(factory provides created pools with the actual version string).Similar to #2032, but using composable pool's deployment branch as base (this is just for this deployment, not a final implementation of this feature).
This PR does not introduce a separate
Versioncontract because that caused a 'stack too deep' error inComposableStablePoolContract, so the functionality is implemented directly in the pool.Merge before #2028 and update the artifacts in that PR.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
See #2026.