Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate managed pool deployment #2044

Merged
merged 5 commits into from
Nov 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/deployments/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
- Deployed `AaveLinearPoolFactory` to all networks.
- Deployed `PoolRecoveryHelper` to all networks.

### Deprecations

- Deprecated `20211021-managed-pool` due to lacking features and not being expected to ever be used. A new version will be released soon.

### API Changes

- Made `getBalancerContractAbi`, `getBalancerContractBytecode`, `getBalancerContractAddress` and `getBalancerDeployment` synchronous rather than asynchronous functions.
Expand Down
2 changes: 1 addition & 1 deletion pkg/deployments/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ Returns an object with all contracts from a deployment and their addresses.
| Composable Stable Pools | [`20220906-composable-stable-pool`](./tasks/20220906-composable-stable-pool) |
| Weighted Pool V2 | [`20220908-weighted-pool-v2`](./tasks/20220908-weighted-pool-v2) |
| Batch Relayer V4 | [`20220916-batch-relayer-v4`](./tasks/20220916-batch-relayer-v4) |
| Managed Pool | [`20221021-managed-pool`](./tasks/20221021-managed-pool) |
| Linear Pools for Aave aTokens with built-in rebalancing | [`20221115-aave-rebalanced-linear-pool`](./tasks/20221115-aave-rebalanced-linear-pool) |
| Pool Recovery Helper | [`20221123-pool-recovery-helper`](./tasks/20221123-pool-recovery-helper) |
| Authorizer Adaptor Entrypoint | [`20221124-authorizer-adaptor-entrypoint`](./tasks/20221124-authorizer-adaptor-entrypoint) |
Expand Down Expand Up @@ -149,3 +148,4 @@ Go to each deprecated deployment's readme file to learn more about why it is dep
| Optimism Root Gauges, for veBAL voting | [`20220628-optimism-root-gauge-factory`](./tasks/deprecated/20220628-optimism-root-gauge-factory) |
| Batch Relayer V3 | [`20220720-batch-relayer-v3`](./tasks/deprecated/20220720-batch-relayer-v3) |
| Linear Pools for Aave aTokens with built-in rebalancing | [`20220817-aave-rebalanced-linear-pool`](./tasks/deprecated/20220817-aave-rebalanced-linear-pool) |
| Managed Pool | [`20221021-managed-pool`](./tasks/deprecated/20221021-managed-pool) |
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Task from '../../src/task';
import { TaskRunOptions } from '../../src/types';
import Task from '../../../src/task';
import { TaskRunOptions } from '../../../src/types';
import { ManagedPoolDeployment } from './input';

export default async (task: Task, { force, from }: TaskRunOptions = {}): Promise<void> => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Task, { TaskMode } from '../../src/task';
import Task, { TaskMode } from '../../../src/task';

export type ManagedPoolDeployment = {
Vault: string;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# 2022-10-21 - Managed Pool Factory

> ⚠️ **DEPRECATED: do not use** ⚠️
>
> This factory and associated Pools have been deprecated due to dependencies requiring extra features: this deployment's Pools are not expected to ever be used.
>
> An updated version will be released soon.

Deployment of the `ManagedPoolFactory`, which allows creating Managed Pools.

A Managed Pool is a Weighted Pool with mutable tokens and weights, designed to be used in conjunction with an owner contract containing specific business logic. This in turn may support many asset management use cases, such as large token counts, rebalancing through token changes, gradual weight or fee updates, fine-grained control of protocol and management fees, allowlisting of LPs, and more.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/dist/src/signer-wit
import { ManagedPoolParams } from '@balancer-labs/v2-helpers/src/models/pools/weighted/types';
import { ProtocolFee } from '@balancer-labs/v2-helpers/src/models/vault/types';

import { getSigner, impersonate, getForkedNetwork, Task, TaskMode, describeForkTest } from '../../../src';
import { getSigner, impersonate, getForkedNetwork, Task, TaskMode, describeForkTest } from '../../../../src';

describeForkTest('ManagedPoolFactory', 'mainnet', 15634000, function () {
let owner: SignerWithAddress, whale: SignerWithAddress, govMultisig: SignerWithAddress;
Expand Down