Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reward tokens apr breakdown #3936

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix reward tokens apr breakdown #3936

merged 1 commit into from
Aug 10, 2023

Conversation

mendesfabio
Copy link
Member

@mendesfabio mendesfabio commented Aug 10, 2023 •
edited
Loading

Description

Shows the reward tokens APR breakdown for pools that have no BAL emission.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

  • Access pools with Staking APR coming from reward tokens and verify the APR tooltip.

Visual context

Before:

image

After:

image

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Aug 10, 2023 6:52pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Aug 10, 2023 6:52pm

@garethfuller garethfuller merged commit cd3637d into master Aug 10, 2023
4 checks passed
@garethfuller garethfuller mentioned this pull request Aug 10, 2023
Merged
@garethfuller garethfuller deleted the hotfix/rewards-apr-breakdown branch August 10, 2023 18:57
garethfuller added a commit that referenced this pull request Aug 11, 2023
@garethfuller @agualis
@timjrobinson @mendesfabio @balopco @zekraken-bot
fix: Limit swap exits (DM) (#3946)
9340c0b 
* Fix ethereum pool links in auto allowlist PRs

* Add test for detecting duplicates in voting list

* Change test name

* chore: Add migration notices (#3934)

* 1.118.1

* hotfix: fix reward tokens apr breakdown (#3936)

* 1.118.2

* chore: Add farmDE pool to polygon allowlist

* add well and stg to whitelist (#3939)

* 1.118.3

* chore: Add 2BTC pool to mainnet allowlist

* Add reth pool to allowlist

* 1.118.4

* chore: Add 80TBTC-20WBTC pool to mainnet allowlist

* 1.118.5

* 1.118.6

* 1.118.7

* 1.118.8

* 1.118.9

* fix: Limit swap exits to deep pools

* chore: Add comment

---------

Co-authored-by: Alberto Gualis <agualis@gmail.com>
Co-authored-by: Tim Robinson <timjrobinson@users.noreply.github.com>
Co-authored-by: Automated Version Bump <gh-action-bump-version@users.noreply.github.com>
Co-authored-by: Fábio Mendes <43360747+mendesfabio@users.noreply.github.com>
Co-authored-by: balopco <balopco@users.noreply.github.com>
Co-authored-by: ZeKraken <79888567+zekraken-bot@users.noreply.github.com>
Co-authored-by: Tim Robinson <tim@timjrobinson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethfuller garethfuller garethfuller approved these changes

@timjrobinson timjrobinson Awaiting requested review from timjrobinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendesfabio @garethfuller