Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI_QUOTES support #196

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

ANSI_QUOTES support #196

wants to merge 6 commits into from

Conversation

zivc
Copy link

@zivc zivc commented Mar 18, 2015

Requires this PR request to be accepted on waterline-sequel,
balderdashy/waterline-sequel#31

@devinivy
Copy link
Contributor

CI "passes" but looks pretty messed-up: https://travis-ci.org/balderdashy/sails-mysql/builds/54893696

@dmarcelino after your work on the adapter tests, any idea why CI thinks this is passing despite failing the first test?

@dmarcelino
Copy link
Member

@devinivy yes, I know. By default the waterline-adapter-tests return 0 (relevant code) unless options.failOnError is set to true which it isn't: https://github.com/balderdashy/sails-mysql/blob/master/test/integration/runner.js#L60-L83

@devinivy
Copy link
Contributor

Will CI always appear to pass for sails-mysql until that changes?

@dmarcelino
Copy link
Member

I believe so, at least that's what I've seen on my tests.

@zivc
Copy link
Author

zivc commented Aug 4, 2015

Any news on getting this merged? Or can we stop using double quotes as identifiers?

@dmarcelino
Copy link
Member

@zivc, this PR breaks the tests and currently is not even mergeable (merge conflicts exist). Until those are addressed we can't merge this.

@zivc
Copy link
Author

zivc commented Aug 4, 2015

I'm sure it wasn't like that before, back in March. I'll take another look at it this weekend.

@particlebanana
Copy link
Contributor

Is this still in an issue that needs to be addressed?

@rkt2spc
Copy link

rkt2spc commented Nov 15, 2018

I got hit by this as well, using an existing DB with ANSI_QUOTES enabled
balderdashy/sails#4549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants