Add support for size attribute for float and decimal types. #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested these in this repo with unit tests and it works. However, something I noticed is that even thought in this repo
sails-mysql
DECIMAL support is there. When I test on my local box with sails, every time I set an attribute to type to DECIMAL by the time it reaches sails-mysql/lib/sql.js the type is STRING instead of DECIMAL. Not sure what is going on there.DECIMAL type is a must for storing monetary values. Not sure why at least from looking at the docs, it's not supported. Since the floating-point (approximate value) types are FLOAT, REAL, and DOUBLE, which they do some rounding. The fixed-point (exact value) types are INTEGER, SMALLINT, DECIMAL, and NUMERIC