Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pg to 4.5.5 #247

Merged
merged 1 commit into from
May 19, 2016
Merged

Update pg to 4.5.5 #247

merged 1 commit into from
May 19, 2016

Conversation

joaosa
Copy link
Contributor

@joaosa joaosa commented May 19, 2016

While coming up with BlueHotDog/sails-migrations#76, I somehow missed sails-migrations's optionalDependencies and ended up updating this project's version of node-postgres to 4.5.5.

This should fix any issues with running this on Node 6, as mentioned on brianc/node-postgres#1000.

Additionally, It appears the tests were failing to begin with. Before the fix, I got:

76 passing (3s)
2 pending
7 failing

Now I get:

80 passing (2s)
2 pending
6 failing

As this doesn't seem to add up, I'm wondering if this final part is an actual improvement or not.

@particlebanana
Copy link
Contributor

It's actually already updated and published for the stable version on npm. https://github.com/balderdashy/sails-postgresql/blob/0.11.x/package.json#L20.

I'll merge this for master though so I don't forget.

@particlebanana particlebanana merged commit b0d8251 into balderdashy:master May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants