Transformation.prototype.unserialize | unserialize the row from DB is not working correctly

[Seafnox]

Sails version: 0.12.11 and 1.0
Node version: 7.4
NPM version: 3.10.9
Operating system: Windows

---

When model contain some transformations by `columnName` it can raise disapearing columns with values.

---

If column names from thee DB (Mongo, MySQL, PostgreSQL, etc.) intersect with field names for user like:

module.exports = {
  attributes: {
    identity: {
      columnName: 'aid',
    },
    ownerId: {
      columnName: 'identity',
    },
    .....
  }
}

then column ownerId resieve right value, but identity value with column was disappearing:

[LOG] Transformation.prototype.unserialize
[LOG] INCOMING DATA: {"aid":120,"name":"explicabo","restriction":65535,"identity":57205}
[LOG] OUTCOMMING DATA: {"restriction":65535,"name":"explicabo","ownerid":57205} - "id" no more exist

For any cases, when column names are intersect like:
a -> b
b -> c
system can loose one of columns

[sailsbot]

Hi @Seafnox! It looks like you may have removed some required elements from the initial comment template, without which I can't verify that this post meets our contribution guidelines. To re-open this issue, please copy the template from here, paste it at the beginning of your initial comment, and follow the instructions in the text. Then post a new comment (e.g. "ok, fixed!") so that I know to go back and check.

Sorry to be a hassle, but following these instructions ensures that we can help you in the best way possible and keep the Sails project running smoothly.

*If you feel this message is in error, or you want to debate the merits of my existence (sniffle), please contact inquiries@sailsjs.com

[sailsbot]

Sorry to be a hassle, but it looks like your issue is still missing some required info. Please double-check your initial comment and try again.

*If you feel this message is in error, or you want to debate the merits of my existence (sniffle), please contact inquiries@sailsjs.com

[sailsbot]

@Seafnox Thanks for posting, we'll take a look as soon as possible.

---

For help with questions about Sails, click here. If you’re interested in hiring @sailsbot and her minions in Austin, click here.

[Seafnox]

I find solution: Instead rewriting exsisting object in Transformation.prototype.unserialize system must create new empty one and unserialize columns from incoming object to created use transformations rules

[Seafnox]

waterline/lib/waterline/utils/system/transformer-builder.js

...
Transformation.prototype.unserialize = function(pRecord) {
  let uRecord = {}
  // Loop through the transformation keys for the record.
  _.each(this._transformations, function(columnName, attrName) {

    if (!_.has(pRecord, columnName)) {
      return;
    }

    uRecord[attrName] = pRecord[columnName];
    delete pRecord[columnName];

  });
  // Merge untransformated columns.
 uRecord = _.extend(uRecord, pRecord);

  return uRecord;
};

[sgress454]

Hi @Seafnox -- thanks for this. Do you think you could make a pull request to Waterline that explains this problem in more detail and includes the fix?

[Seafnox]

i'll try

[sailsbot]

@Seafnox,@sailsbot,@sgress454: Hello, I'm a repo bot-- nice to meet you!

It has been 30 days since there have been any updates or new comments on this page. If this issue has been resolved, feel free to disregard the rest of this message and simply close the issue if possible. On the other hand, if you are still waiting on a patch, please post a comment to keep the thread alive (with any new information you can provide).

If no further activity occurs on this thread within the next 3 days, the issue will automatically be closed.

Thanks so much for your help!

[sailsbot]

@Seafnox,@sailsbot,@sgress454: Hello, I'm a repo bot-- nice to meet you!

It has been 30 days since there have been any updates or new comments on this page. If this issue has been resolved, feel free to disregard the rest of this message and simply close the issue if possible. On the other hand, if you are still waiting on a patch, please post a comment to keep the thread alive (with any new information you can provide).

If no further activity occurs on this thread within the next 3 days, the issue will automatically be closed.

Thanks so much for your help!

[sailsbot]

@Seafnox,@sailsbot,@sgress454: Hello, I'm a repo bot-- nice to meet you!

It has been 30 days since there have been any updates or new comments on this page. If this issue has been resolved, feel free to disregard the rest of this message and simply close the issue if possible. On the other hand, if you are still waiting on a patch, please post a comment to keep the thread alive (with any new information you can provide).

If no further activity occurs on this thread within the next 3 days, the issue will automatically be closed.

Thanks so much for your help!