Disabling CSRF via web-sockets accessed routes #2732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you do a post to a route which is in the `sails.config.csrf.routesDisabled` string via a web-socket CSRF was not disabled.
|
@juulderuysscher hmm I'm not sure I'm ok with doing this-- if we disable CSRF for sockets, how will we deal with socket hijacking? Here's how we normally suggest using CSRF over websockets -- would you try that out? Let me know if you run into difficulties. Thanks! |
sgress454
added a commit
that referenced
this pull request
Jan 20, 2016
-- Add req.originalUrl -- Compute req.path -- Compute req.query based on path -- Fix wantsJSON to allow `false` value, FWIW refs #2732
ctartist621
pushed a commit
to ctartist621/sails
that referenced
this pull request
Feb 3, 2016
-- Add req.originalUrl -- Compute req.path -- Compute req.query based on path -- Fix wantsJSON to allow `false` value, FWIW refs balderdashy#2732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you do a post to a route which is in the
sails.config.csrf.routesDisabledstring via a web-socket CSRF was not disabled.