Make underscore and async globals configurable #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikermcneil
added a commit
that referenced
this pull request
Apr 9, 2013
Make underscore and async globals configurable
|
Thanks! |
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should respect the flag in the default configuration file for globalizing
underscoreandasync.It also fixes the flag in waterline for globalizing models. It just needed to be moved under the collections key.
As we discussed in #295 the sails global can't be removed without breaking the controller conventions currently in use.
I didn't do anything regarding the global adapters setting because it doesn't look like its used. The adapters are attached to the sails global but the option exists in the default config file.
This should fix #299 but you may want to go through and ensure it doesn't break anything you guys are using in production apps. Let me know if you see any issues.