Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixes #3901] fix mis typed variable names in badLocalDependency() #3902

Merged
merged 1 commit into from
Nov 22, 2016
Merged

[fixes #3901] fix mis typed variable names in badLocalDependency() #3902

merged 1 commit into from
Nov 22, 2016

Conversation

Hiro-Nakamura
Copy link

fixes #3901

I fixed the mistyped variable names.

I also used requiredVersion to follow the pattern in incompatibleLocalSails()

@sailsbot
Copy link

Thanks for posting, @Hiro-Nakamura! We'll look into this ASAP.

@mikermcneil
Copy link
Member

@Hiro-Nakamura thank you!

@mikermcneil mikermcneil merged commit 5232d6a into balderdashy:0.12 Nov 22, 2016
mikermcneil added a commit that referenced this pull request Nov 22, 2016
@mikermcneil
Rebase fix from #3902 and update changelog.
bdefb43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hiro-Nakamura @sailsbot @mikermcneil