Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added back in res.view layout attribute. #573

Merged
merged 1 commit into from
Jul 14, 2013

Conversation

dubcanada
Copy link
Contributor

Hey,

I was playing around with the new 0.9-RC and my

res.view('file', { layout: 'test' });

was not working as it was being overwrote. I re-added this back in.

On another note, is there a reason that

<% layout('boilerplate') -%>

Doesn't work?

@mikermcneil
Copy link
Member

hey @dubcanada, res.layout was removed in Express 3 as a built-in feature. We're using ejs-locals to support the old behavior as well, but I'm still unsure on the final outcome of that (last thing I want to do is create any incompatibilities with new Express apps)

I'm down to merge this- but I wanted to make sure you were aware first and see if anyone had run into any problems around this from the other direction.

Thanks!

@dubcanada
Copy link
Contributor Author

I tried using the <% layout('boilerplate') -%> code and that didn't work, errored saying something about layout missing function.

So I wasn't sure how to properly do that as ejs-locals says to use <% layout('boilerplate') -%>

@mikermcneil
Copy link
Member

Thanks-- i've got to make sure that works for the default layout anyways, so I'll merge and work backwards

mikermcneil added a commit that referenced this pull request Jul 14, 2013
Re-added back in res.view layout attribute.
@mikermcneil mikermcneil merged commit 79d95f2 into balderdashy:development Jul 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants