Return empty/zero from IN w/empty array

[slester]

Calling Collection.destroy({id: []}) destroys all documents. Functionality exists in normalize that returns false if there's an empty array, but false is OR'd with {}, resulting in a {} being passed to the sails-mongo adapter, which deletes everything.

This PR just applies what is already implemented for find().

We found this out the hard way. :(

[dmarcelino]

This seems reasonable to me, it makes destroy and find consistent, and protects users from deleting all their records accidentally ✅

@slester, I would love if this PR included an automated test... :)

@devinivy, what are your thoughts?

[devinivy]

Just to make sure I understand, how would the specific call Collection.destroy() behave?

[slester]

@devinivy Collection.destroy({id: []}) should return a callback with no error but also an empty "deleted" array. Right now, it behaves exactly like Collection.destroy({}).

[slester]

@dmarcelino Added a unit test!

[dmarcelino]

Cool! 😀

[devinivy]

@slester what would Collection.destroy() do, exactly as typed? I know some libraries use that to clear a table, such as sails-relational-fixtures.

[slester]

@devinivy Collection.destroy() will do the same thing as Collection.destroy({}), namely delete everything in the collection. That behavior won't be changed in our code.

[devinivy]

Cool– sounds good :)

[slester]

Let me know if anything is lacking for this PR!

[tjwebb]

+1

[dmarcelino]

Thanks @slester!