Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mocha unit test framework #339

Merged
merged 2 commits into from
Nov 16, 2017
Merged

Conversation

LucianBuzzo
Copy link
Contributor

@LucianBuzzo LucianBuzzo commented Nov 16, 2017

Includes a basic test file, mainly as an example and a jumping-off point

change-type: minor


Contributor checklist
  • Build output been rebuilt and tested
  • Introduces security considerations
  • Tests are included
  • Documentation is added or changed
  • Affects the development, build or deployment processes of the component
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@@ -0,0 +1,27 @@
/// <reference types="mocha" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need this - I think if you just remove it everything should work without...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought as well, but there are some issues with ts-node not picking up @types declarations with this combination of TS and mocha.
TypeStrong/ts-node#271
I tried a few different options, and this was the cleanest solution, I'd like to come back and resolve this in the future though.

Copy link
Contributor

@hedss hedss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah!

Includes a basic test file, mainly as an example and a jumping-off point

change-type: minor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants