Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react dependecies #1585

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Update react dependecies #1585

wants to merge 12 commits into from

Conversation

JSReds
Copy link
Contributor

@JSReds JSReds commented May 4, 2022

WORK IN PROGRESS

Missing steps:

  1. replace react-monaco-editor with something else (porbably @monaco-editor/react should be good) => revert
  2. src/components/Renderer/RendererPlayground/index.tsx .storybook/main.js
  3. fix autoUIApp error (screenshot below)
  4. fix all errors ( build errors as well )
  5. fix tests
  6. test all components

Screenshot 2022-05-10 at 17 28 23

Change-type: minor
Signed-off-by: Andrea Rosci andrear@balena.io

Connects-to: #
See:
Depends-on:
Change-type: major|minor|patch


Contributor checklist
  • I have regenerated jest snapshots for any affected components with npm run generate-snapshots
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@iamsolankiamit
Copy link
Contributor

simplemde needs to publish its latest version to fix its typings see

@iamsolankiamit iamsolankiamit marked this pull request as ready for review September 21, 2022 16:53
@iamsolankiamit
Copy link
Contributor

About autoUIApp I had to switch back to v5.2.0 of react router as storybook doesn't work with v6 see this storybookjs/storybook#16837

@iamsolankiamit
Copy link
Contributor

React router advises not to switch to v6 , until they build backward compatibility see https://reactrouter.com/en/v6.3.0/upgrading/v5
Screenshot 2022-09-21 at 10 29 02 PM

@iamsolankiamit iamsolankiamit marked this pull request as draft September 21, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants