Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resin-compose-parse from 2.1.3 to 2.3.0 #2365

Closed
wants to merge 1 commit into from

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Oct 19, 2021

This adds support for Docker compose v2.4

Closes: #2364
Change-type: patch
Signed-off-by: Tomás Migone tomas@balena.io

This adds support for Docker compose v2.4

Closes: #2364
Change-type: patch
Signed-off-by: Tomás Migone <tomas@balena.io>
@tmigone tmigone requested review from pdcastro and robertgzr October 19, 2021 20:01
@tmigone
Copy link
Contributor Author

tmigone commented Oct 19, 2021

@robertgzr @pdcastro any other places I should update this other than the builder?

@tmigone
Copy link
Contributor Author

tmigone commented Oct 19, 2021

Just saw these:

I think we can close this then but, don't we need to update resin-compose-parse to 2.3.0 also in the respective package.json files (here and here)?

@pdcastro
Copy link
Contributor

I think we can close this then but, don't we need to update resin-compose-parse to 2.3.0 also in the respective package.json files (here and here)?

Yes and yes (and yes), resin-compose-parse needs to be updated in the package.json files of CLI and builder, but also it is probably a good idea to close this PR in favour of #2358 and balena-io/balena-builder/pull/904 because resin-multibuild itself imports resin-compose-parse, and I think it would save testing effort and make debugging easier if the same PR bumped the versions of both resin-multibuild and resin-compose-parse at the same time, matching the version of resin-compose-parse imported by resin-multibuild.

@pdcastro pdcastro closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update resin-compose-parse version to 2.3.0
2 participants