Replace resin-discoverable-services with bonjour-service #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviojacobi
force-pushed
the
replace-discoverable-service-for-std-bonjour-service
branch
3 times, most recently
from
ae8f292
to
8d212ab
Compare
otaviojacobi
requested review from
thgreasi,
ab77,
myarmolinsky,
klutchell and
dfunckt
dfunckt
reviewed
Jul 10, 2024
otaviojacobi
force-pushed
the
replace-discoverable-service-for-std-bonjour-service
branch
2 times, most recently
from
6e2df0d
to
44deb09
Compare
dfunckt
reviewed
Jul 10, 2024
otaviojacobi
force-pushed
the
replace-discoverable-service-for-std-bonjour-service
branch
2 times, most recently
from
2798e1d
to
4820917
Compare
otaviojacobi
force-pushed
the
replace-discoverable-service-for-std-bonjour-service
branch
from
4820917
to
7993d43
Compare
myarmolinsky
approved these changes
Jul 10, 2024
Instead of using the more generic resin-discoverable-services lib which is unmantained and currently has several vulnerabilities and forks for fixing issues (that were later on fixed upstream) we directly talk with mDNS using standard (and currently mantained) bonjour-service. Change-type: patch
otaviojacobi
force-pushed
the
replace-discoverable-service-for-std-bonjour-service
branch
from
7993d43
to
7273656
Compare
flowzone-app
bot
deleted the
replace-discoverable-service-for-std-bonjour-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the more generic resin-discoverable-services lib which is unmantained and currently has several vulnerabilities and forks for fixing issues (that were later on fixed upstream) we directly talk with mDNS using standard (and currently mantained) bonjour-service.
Change-type: patch
Resolves: #
Change-type: major|minor|patch
Depends-on:
See:
Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.
Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.
If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.
If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.
Thank you very much for your contribution!