Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sudo-prompt): Use a fork of sudo-prompt #2469

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Conversation

zvin
Copy link
Contributor

@zvin zvin commented Sep 6, 2018

This is to avoid running the child-writer twice when the hostname isn't
set in /etc/hosts. See jorangreef/sudo-prompt#76

Change-type: patch
Signed-off-by: Alexis Svinartchouk alexis@resin.io

npm-shrinkwrap.json Outdated Show resolved Hide resolved
"sudo-prompt": {
"version": "8.0.0",
"resolved": "https://registry.npmjs.org/sudo-prompt/-/sudo-prompt-8.0.0.tgz"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong, now this only removes sudo-prompt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, updated

@zvin
Copy link
Contributor Author

zvin commented Sep 6, 2018

@resin-ci retest

@zvin zvin force-pushed the fix-double-flash branch 3 times, most recently from 2883d5d to d478643 Compare September 17, 2018 12:33
@zvin
Copy link
Contributor Author

zvin commented Sep 19, 2018

@resin-ci retest

1 similar comment
@zvin
Copy link
Contributor Author

zvin commented Sep 20, 2018

@resin-ci retest

@zvin zvin force-pushed the fix-double-flash branch 2 times, most recently from bdfc6c0 to a2d5911 Compare September 26, 2018 08:42
@zvin
Copy link
Contributor Author

zvin commented Sep 26, 2018

@resin-ci retest

1 similar comment
@zvin
Copy link
Contributor Author

zvin commented Sep 27, 2018

@resin-ci retest

This is to avoid running the child-writer twice when the hostname isn't
set in /etc/hosts. See jorangreef/sudo-prompt#76

Change-type: patch
Signed-off-by: Alexis Svinartchouk <alexis@resin.io>
@ghost ghost assigned thundron Sep 27, 2018
@thundron thundron merged commit 9abca20 into master Sep 27, 2018
@ghost ghost removed the in progress label Sep 27, 2018
@thundron thundron deleted the fix-double-flash branch November 12, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants