Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the device permissions explicit #78

Open
richbayliss opened this issue Apr 17, 2019 · 0 comments
Open

Make the device permissions explicit #78

richbayliss opened this issue Apr 17, 2019 · 0 comments

Comments

@richbayliss
Copy link
Contributor

The permission resin.device.all is allowing all ports to be available to tunnel unintentionally. This should be broken down to create, read, update and delete.

Additionally we would like to keep the ability to tunnel any port, so we will add a new permission resin.device.tunnel-any which can be checked for.

Please see balena-io/open-balena#47 for the original issue.

richbayliss pushed a commit that referenced this issue Apr 17, 2019
The permission `resin.device.all` allowed any port to be tunnelled
by mistake, rather than intention. This permission is now broken
down to the component actions create, read, update and delete.

The existing `tunnel-22222` is kept, but also added is a rule to
allow the `tunnel-any` action. It is desirable that any port could
be tunnelled and this permission will be checked by the connect proxy
alongside the explicit port permission.

Change-type: patch
Signed-off-by: Rich Bayliss <rich@balena.io>
Connects-to: #78
richbayliss pushed a commit that referenced this issue May 17, 2019
The permission `resin.device.all` allowed any port to be tunnelled
by mistake, rather than intention. This permission is now broken
down to the component actions create, read, update and delete.

The existing `tunnel-22222` is kept, but also added is a rule to
allow the `tunnel-any` action. It is desirable that any port could
be tunnelled and this permission will be checked by the connect proxy
alongside the explicit port permission.

Change-type: patch
Signed-off-by: Rich Bayliss <rich@balena.io>
Connects-to: #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant