upgrade-2.x: Block draft version upgrades using the release_tag version #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this, HUPing to draft-OS releases will only work using the raw_version. The reasoning is to blocks users from accidentally HUPing to a draft release. This also removes the ambiguity that we atm have, where for a draft release 3.2.1-2345, users can perform the same HUP using either 3.2.1-2345 (found via the raw_version field) and also with 3.2.1 (found via the release_tag). Partially reverts commit ce70f31. Change-type: patch
thgreasi
force-pushed
the
block-tag-based-draft-os-hups
branch
from
0719f7f
to
8ff13de
Compare
klutchell
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atm given a draft OS release 3.2.1-2345, users would be able to HUP to it via both
device os-update 3.2.1-2345, in which case the script finds the version via theraw_versionfielddevice os-update 3.2.1, in which case the script find the version via therelease_tagAfter this, HUPing to draft-OS releases will only work using the
raw_versionwhich removes the ambiguity and block users from accidentally HUPing to a draft release (eg they misstype the patch version or on purpose try to increase it to check whether a new version is out).Partially reverts commit ce70f31.
Change-type: patch
See: https://balena.fibery.io/Work/Improvement/Remove-hostApp-version-release-tag-dependency-from-API-1412