Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from the changes that introduced non-LUKS encryption support #3566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexgg
Copy link
Contributor

@alexgg alexgg commented Nov 27, 2024


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Adapt the grub update hook to the changes introduced in
d50e221

Change-type: patch
Signed-off-by: Alex Gonzalez <alexg@balena.io>
The LUKS configuration now lives in the flasher configuration file.

Change-type: patch
Signed-off-by: Alex Gonzalez <alexg@balena.io>
@alexgg alexgg requested a review from jakogut November 27, 2024 09:05
@alexgg
Copy link
Contributor Author

alexgg commented Nov 27, 2024

Tests on generic-amd64

Copy link
Contributor

flowzone-app bot commented Nov 27, 2024

Website deployed to CF Pages, 👀 preview link https://628f9709.balena-os.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant