-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to use Vite instead of Create React App #515
Open
thienandangthanh
wants to merge
25
commits into
balena-os:master
Choose a base branch
from
thienandangthanh:migration/vite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate to use Vite instead of Create React App #515
thienandangthanh
wants to merge
25
commits into
balena-os:master
from
thienandangthanh:migration/vite
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copy src directory - move public/index.html to index.html - remove %PUBLIC_URL% - add module script to the bottom of the body tag
Reason: to match create-react-app output
Reason: %PUBLIC_URL% is not used with vite
thienandangthanh
force-pushed
the
migration/vite
branch
from
November 7, 2023 18:33
48e1ae1
to
43a5e4f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Reason: to serve with wifi-connect binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #514
What have been done
husky
andlint-staged
create-react-app
withvite
Reference