Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions of security BBEs #1886

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

ldclakmal
Copy link
Member

@ldclakmal ldclakmal commented Jun 2, 2021

Purpose

$subject

Removed the instruction:

# To start the service, navigate to the directory that contains the
# `.bal` file and use the `bal run` command below.

Related to ballerina-platform/ballerina-library#584

@@ -1,5 +1,3 @@
# To run this sample, navigate to the directory that contains the `.bal` file,
# and execute the `bal run` command below.
# (You may need to change the certificate file path and private key file path.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these brackets anymore? Since this is the only instruction here, we can remove the bracket, right? Check the other place as well.

Copy link
Member Author

@ldclakmal ldclakmal Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Fixed with 7355b26

@ldclakmal ldclakmal merged commit 85b09a9 into ballerina-platform:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants