Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Integrate error semtype into jBallerina type engine #42811

Closed
lochana-chathura opened this issue May 27, 2024 · 4 comments
Closed
Assignees
Labels
Area/SemtypeIntegration Issue related to integrating semtype engine Area/TypeChecker Type Checker related issues #Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement

Comments

@lochana-chathura
Copy link
Member

lochana-chathura commented May 27, 2024

Description

$subject.

@lochana-chathura lochana-chathura added Type/Improvement Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Area/TypeChecker Type Checker related issues #Compiler labels May 27, 2024
@lochana-chathura lochana-chathura moved this to Planned for Sprint in Ballerina Team Main Board May 27, 2024
@lochana-chathura lochana-chathura self-assigned this May 29, 2024
@lochana-chathura lochana-chathura moved this from Planned for Sprint to In Progress in Ballerina Team Main Board May 30, 2024
@lochana-chathura
Copy link
Member Author

After integrating a test failure for the following narrowed sample.

type M map<Cloneable>;

// @type M < MC
type MC map<any|E>;

type E error<map<Cloneable>>;

type Cloneable readonly|Cloneable[]|map<Cloneable>;

Looking into it.

@lochana-chathura
Copy link
Member Author

The reason for the above failure is, in the semtype environment we pre-define the readonly type. It includes the types that are not integrated into the compile-time. It is causing the above test failure.

@lochana-chathura lochana-chathura moved this from In Progress to On Hold in Ballerina Team Main Board Jun 11, 2024
@lochana-chathura lochana-chathura moved this from On Hold to In Progress in Ballerina Team Main Board Jun 12, 2024
@lochana-chathura
Copy link
Member Author

The reason for the above failure is, in the semtype environment we pre-define the readonly type. It includes the types that are not integrated into the compile-time. It is causing the above test failure.

Well, to fix this we need two environments for ported semtype tests and jballerina unit tests which only support part of the semtypes. It was achieved using a system property as per 10f0ced.

@lochana-chathura
Copy link
Member Author

Closing with #42912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypeIntegration Issue related to integrating semtype engine Area/TypeChecker Type Checker related issues #Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement
Projects
Archived in project
Development

No branches or pull requests

1 participant