Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate error semtype into compiler #42912

Conversation

lochana-chathura
Copy link
Member

@lochana-chathura lochana-chathura commented Jun 12, 2024

Purpose

$subject.

Fixes #42811
Fixes #43030

Approach

n/a

Samples

n/a

Remarks

n/a

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lochana-chathura lochana-chathura added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Jun 12, 2024
@lochana-chathura lochana-chathura marked this pull request as ready for review June 13, 2024 06:29
@lochana-chathura lochana-chathura added the Area/SemtypeIntegration Issue related to integrating semtype engine label Jun 28, 2024
@lochana-chathura lochana-chathura marked this pull request as draft July 3, 2024 05:43
@lochana-chathura lochana-chathura marked this pull request as ready for review July 3, 2024 14:47
Copy link
Member

@heshanpadmasiri heshanpadmasiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 77.19298% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.37%. Comparing base (ec7d084) to head (58f41b3).
Report is 1 commits behind head on nutcracker.

Files Patch % Lines
...llerinalang/compiler/bir/writer/BIRTypeWriter.java 0.00% 3 Missing ⚠️
...alang/compiler/semantics/analyzer/SymbolEnter.java 33.33% 2 Missing ⚠️
.../ballerinalang/compiler/BIRPackageSymbolEnter.java 80.00% 1 Missing ⚠️
...g/wso2/ballerinalang/compiler/desugar/Desugar.java 0.00% 1 Missing ⚠️
.../compiler/semantics/analyzer/SemanticAnalyzer.java 0.00% 1 Missing ⚠️
...compiler/semantics/analyzer/TypeParamAnalyzer.java 0.00% 1 Missing ⚠️
...ang/compiler/semantics/model/types/BErrorType.java 91.66% 0 Missing and 1 partial ⚠️
semtypes/src/main/java/io/ballerina/types/Env.java 75.00% 1 Missing ⚠️
...mtypes/src/main/java/io/ballerina/types/Error.java 80.00% 0 Missing and 1 partial ⚠️
...ain/java/io/ballerina/types/PredefinedTypeEnv.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             nutcracker   #42912      +/-   ##
================================================
+ Coverage         77.36%   77.37%   +0.01%     
- Complexity        52390    52414      +24     
================================================
  Files              2996     2996              
  Lines            207902   207927      +25     
  Branches          27192    27196       +4     
================================================
+ Hits             160833   160888      +55     
+ Misses            38209    38195      -14     
+ Partials           8860     8844      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lochana-chathura lochana-chathura merged commit ffaac5c into ballerina-platform:nutcracker Jul 16, 2024
17 of 18 checks passed
@lochana-chathura lochana-chathura deleted the semIntegration/error branch July 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypeIntegration Issue related to integrating semtype engine Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants