Improve xml index expr type checking

[rdhananjaya]

Emit warning when deprecated child access is used. (Fixes #22053)
Emit error when non int/string index is used. (Fixes #22052)

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[codecov-io]

Codecov Report

Merging #22088 into ballerina-1.2.x will not change coverage by %.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.2.x   #22088   +/-   ##
================================================
  Coverage            14.59%   14.59%           
================================================
  Files                   51       51           
  Lines                 1411     1411           
  Branches               219      219           
================================================
  Hits                   206      206           
  Misses                1189     1189           
  Partials                16       16           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef12717...7abcec6. Read the comment docs.

[MaryamZi]

The PR to the master branch #22106 was merged.

[hasithaa]

@rdhananjaya Did we add this fix to master?

Found the PR. #22106