-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configurable variables of record
& table
types
#28461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HindujaB
changed the title
[WIP] Support configurable variables of
Support configurable variables of Feb 6, 2021
record
& table
typesrecord
& table
types
HindujaB
added
the
Team/jBallerina
All the issues related to BIR, JVM backend code generation and runtime
label
Feb 6, 2021
HindujaB
requested review from
warunalakshitha,
riyafa,
Kishanthan,
gabilang and
manuranga
February 7, 2021 03:33
manuranga
reviewed
Feb 7, 2021
...na-integration-test/src/test/java/org/ballerinalang/test/configurables/ConfigurableTest.java
Show resolved
Hide resolved
HindujaB
force-pushed
the
record-config
branch
from
February 8, 2021 10:22
9dc8263
to
6e8bd87
Compare
HindujaB
commented
Feb 8, 2021
...na-integration-test/src/test/java/org/ballerinalang/test/configurables/ConfigurableTest.java
Show resolved
Hide resolved
HindujaB
commented
Feb 8, 2021
...erina-runtime/src/main/java/io/ballerina/runtime/internal/configurable/ConfigTomlParser.java
Outdated
Show resolved
Hide resolved
HindujaB
commented
Feb 8, 2021
...erina-runtime/src/main/java/io/ballerina/runtime/internal/configurable/ConfigTomlParser.java
Outdated
Show resolved
Hide resolved
HindujaB
commented
Feb 8, 2021
...erina-runtime/src/main/java/io/ballerina/runtime/internal/configurable/ConfigTomlParser.java
Outdated
Show resolved
Hide resolved
HindujaB
commented
Feb 8, 2021
...ntegration-test/src/test/resources/configurables/NegativeTests/AdditionalField/main/main.bal
Outdated
Show resolved
Hide resolved
HindujaB
force-pushed
the
record-config
branch
from
February 8, 2021 14:49
6e8bd87
to
cb05d64
Compare
riyafa
reviewed
Feb 8, 2021
...erina-runtime/src/main/java/io/ballerina/runtime/internal/configurable/ConfigTomlParser.java
Outdated
Show resolved
Hide resolved
HindujaB
force-pushed
the
record-config
branch
from
February 8, 2021 16:09
cb05d64
to
05a0a87
Compare
tests/ballerina-test-utils/src/main/java/org/ballerinalang/test/BRunUtil.java
Show resolved
Hide resolved
HindujaB
force-pushed
the
record-config
branch
from
February 8, 2021 22:15
05a0a87
to
a238a08
Compare
LGTM |
riyafa
reviewed
Feb 9, 2021
...na-integration-test/src/test/java/org/ballerinalang/test/configurables/ConfigurableTest.java
Show resolved
Hide resolved
...allerina-integration-test/src/test/resources/configurables/configurableProject/main/main.bal
Show resolved
Hide resolved
...integration-test/src/test/resources/configurables/negative_tests/additionalField/Config.toml
Show resolved
Hide resolved
warunalakshitha
approved these changes
Feb 9, 2021
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
record
type configurable variablestable
type configurable variablesFixes #28091
Approach
Ballerina context
Toml context
Ballerina context
Toml context
Samples
Remarks
related issues
ballerina-platform/ballerina-library#862
ballerina-platform/ballerina-spec#709
The following aspects are considered in implementation
(Supported field types :
int
,float
,string
,boolean
,decimal
& array of these types )Check List