Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HTTP filters desugar class #31114

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Conversation

ldclakmal
Copy link
Member

@ldclakmal ldclakmal commented Jun 11, 2021

Purpose

The $subject was done since this is not longer related to HTTP filters and it does only desugaring a particular method for services which is used for declarative auth design of stdlibs.

Related to: ballerina-platform/ballerina-library#584

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@rdhananjaya rdhananjaya added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Lang/ListenerDeclaration Issues related to listener declarations. labels Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #31114 (ba35b9f) into master (a411f23) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31114   +/-   ##
=========================================
  Coverage     70.45%   70.46%           
- Complexity    37916    37920    +4     
=========================================
  Files          2840     2840           
  Lines        155921   155921           
  Branches      19505    19505           
=========================================
+ Hits         109861   109872   +11     
+ Misses        39672    39663    -9     
+ Partials       6388     6386    -2     
Impacted Files Coverage Δ
...alang/compiler/desugar/DeclarativeAuthDesugar.java 22.78% <100.00%> (ø)
...ballerinalang/compiler/desugar/ServiceDesugar.java 92.24% <100.00%> (ø)
...n/java/io/ballerina/projects/bala/BalaProject.java 81.57% <0.00%> (-5.27%) ⬇️
...viders/context/ListenerDeclarationNodeContext.java 74.23% <0.00%> (+0.61%) ⬆️
.../ballerina/runtime/internal/scheduling/Strand.java 82.47% <0.00%> (+2.57%) ⬆️
...runtime/internal/scheduling/WorkerDataChannel.java 89.17% <0.00%> (+4.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a411f23...ba35b9f. Read the comment docs.

@ldclakmal ldclakmal merged commit f760004 into ballerina-platform:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lang/ListenerDeclaration Issues related to listener declarations. Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants