-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service type inference #33842
Fix service type inference #33842
Conversation
328e7e0
to
0fcb89c
Compare
Codecov Report
@@ Coverage Diff @@
## stage-slbeta4 #33842 +/- ##
===================================================
- Coverage 71.04% 70.90% -0.15%
+ Complexity 43239 43168 -71
===================================================
Files 3139 3139
Lines 175016 175075 +59
Branches 22592 22608 +16
===================================================
- Hits 124345 124129 -216
- Misses 43569 43871 +302
+ Partials 7102 7075 -27
Continue to review full report at Codecov.
|
return { output: "Hello" }; | ||
} | ||
|
||
function createError() returns @tainted error? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do we still use @tainted
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not needed. Should be a copied code.
Purpose
Improve service type inference
Fixes #33873
Approach
Samples
Remarks
Check List