Generate a typedesc instruction once for record and tuple types #39101

chiranSachintha · 2022-12-17T19:25:40Z

Purpose

$title.

Check List

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java

MaryamZi · 2022-12-21T06:31:34Z

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java

+    }
+
+    @Override
+    public void visit(BLangFunctionTypeNode functionTypeNode) {


Don't we have to visit parameter and return types?

It is not possible to assign a value to the parameters of a function node. And also no usage in creating a type descriptor for the return value

What about

public function main() { function (record {| float f; |}) returns record {| string b = "hello"; |} y; }

Where are the new typedesc instructions generated for these records?

Didn't generate typedesc for this because there is no usage of defining typedescs for these records.

What do you mean no usage?

import ballerina/io; annotation record {| float f = foo(); |} annot on record field; public function main() { function (record {| @annot float f; |}) r; } isolated function foo() returns float { io:println("foo"); return 1.0; }

This should print "foo", but it doesn't atm.

Either way, we shouldn't make assumptions about usage. The spec defines when the typedesc is resolved, and we have to resolve it at that point.

I assume we need changes in #38488 for the sample I shared above to work as expected? We need to make sure we have tests for every possible type node scenario.

Did we add this as a test in the other PR?

@chiranSachintha, any update on this? Doesn't seem to work for me with the other PR also, will recheck.

Can you send a draft PR with changes from both PRs, resolving conflicts?

MaryamZi · 2022-12-21T06:32:09Z

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java

+            if (field.typeNode != null) {
+                field.typeNode.accept(this);
+            }
+        }


How about the param/return types in methods?

When defining an object, the methods of the object are added to a function list and when visiting the function list, type descriptors for the parameters and return type will be created(no need to generate type descriptors here).

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java

...ler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/ClosureDesugar.java

...ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/model/BIRNonTerminator.java

...lerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmInstructionGen.java

…ina-lang into new-typedesc

codecov · 2023-01-03T15:45:21Z

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3adfbf0) 76.35% compared to head (1cf271a) 76.83%.
Report is 131 commits behind head on master.

❗ Current head 1cf271a differs from pull request most recent head 2299e82. Consider uploading reports for the commit 2299e82 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #39101      +/-   ##
============================================
+ Coverage     76.35%   76.83%   +0.47%     
- Complexity    52520    53442     +922     
============================================
  Files          2881     3347     +466     
  Lines        198492   199736    +1244     
  Branches      25807    25813       +6     
============================================
+ Hits         151565   153464    +1899     
+ Misses        38563    37680     -883     
- Partials       8364     8592     +228

Files	Coverage Δ
...java/io/ballerina/runtime/api/utils/TypeUtils.java	`20.00% <ø> (-5.59%)`	⬇️
...ava/io/ballerina/runtime/internal/TypeChecker.java	`78.53% <100.00%> (-2.30%)`	⬇️
...ina/runtime/internal/types/BTypeReferenceType.java	`92.85% <100.00%> (+0.85%)`	⬆️
.../ballerina/runtime/internal/util/RuntimeUtils.java	`46.87% <100.00%> (+16.76%)`	⬆️
...allerina/runtime/internal/values/MapValueImpl.java	`90.43% <100.00%> (+1.54%)`	⬆️
...org/wso2/ballerinalang/compiler/bir/BIRGenEnv.java	`100.00% <100.00%> (ø)`
...llerinalang/compiler/bir/codegen/JvmConstants.java	`100.00% <ø> (ø)`
...nalang/compiler/bir/codegen/JvmInstructionGen.java	`89.90% <100.00%> (-0.49%)`	⬇️
...ballerinalang/compiler/bir/codegen/JvmTypeGen.java	`91.43% <100.00%> (-1.92%)`	⬇️
...compiler/bir/codegen/split/JvmMethodsSplitter.java	`100.00% <100.00%> (ø)`
... and 12 more

... and 1374 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…rence to a referred type

github-actions · 2023-09-13T19:33:14Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2023-09-17T19:33:08Z

Closed PR due to inactivity for more than 18 days.

…ina-lang into new-typedesc # Conflicts: # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/types/JvmRecordTypeGen.java

github-actions · 2023-10-17T19:33:15Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2023-11-02T19:33:12Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2023-11-05T19:33:22Z

Closed PR due to inactivity for more than 18 days.

github-actions · 2023-11-21T19:33:18Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

chiranSachintha · 2024-01-08T04:04:15Z

I have opened a new PR for this change as we have modified the logic(#41945)

chiranSachintha added 6 commits December 18, 2022 00:39

Set owner of generated type definitions

5b8006c

Add type details to NewStructure instruction

34f322f

Add details of enclosure map symbols to record type

013bafe

Use record reference type when creating mapping value

cd8d4a8

Create runtime type instance only for the user defined type definitions

679b9fa

Fix checkstyle issues

dd89697

chiranSachintha requested review from sameerajayasoma and hasithaa as code owners December 17, 2022 19:25

chiranSachintha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Dec 17, 2022

chiranSachintha requested review from warunalakshitha, suleka96, MaryamZi and dulajdilshan December 17, 2022 19:26

MaryamZi reviewed Dec 21, 2022

View reviewed changes

MaryamZi mentioned this pull request Dec 21, 2022

Support for field annotations in local records and tuples #38488

Merged

13 tasks

chiranSachintha added 4 commits January 3, 2023 08:52

Merge branch 'master' of https://github.com/ballerina-platform/baller…

62293d5

…ina-lang into new-typedesc

Generate separate method to create typedesc instances

c3c7690

BIR test update

193eb74

Add typedesc details to NewArray instruction

08af771

chiranSachintha added 2 commits January 4, 2023 15:31

Use PackageID of type

e0ce035

Generate a typedesc instruction once for record and tuple types

ed9d56f

chiranSachintha changed the title ~~Generate new typedesc instruction for record when typedesc resolving~~ Generate a typedesc instruction once for record and tuple types Jan 9, 2023

chiranSachintha added 5 commits January 10, 2023 00:56

Implemente visitors for type node

955f2eb

Add BTypeReferenceType constructor for creating a read-only type refe…

89b4981

…rence to a referred type

Generate type definition for tuple intersection with readonly

e5875ba

Update BIR test

2097769

Update error meesage

4f85ee5

chiranSachintha requested a review from MaryamZi January 10, 2023 03:38

Use referred type of type reference

722f9e1

github-actions bot added the Stale label Aug 28, 2023

chiranSachintha removed the Stale label Aug 29, 2023

github-actions bot added the Stale label Sep 13, 2023

github-actions bot closed this Sep 17, 2023

chiranSachintha removed the Stale label Sep 18, 2023

Get annotation from typedesc

6f37020

chiranSachintha reopened this Oct 2, 2023

chiranSachintha marked this pull request as draft October 2, 2023 06:53

chiranSachintha added 6 commits October 2, 2023 12:24

Rearrange top level nodes for improve order

5072e8c

Implement Block Statement for store TypeNode Details

182e46c

Add global variables to top level nodes

64522f5

Generate a typedesc instruction when visiting type node

05f67bc

Desugar local record type nodes

c99c7d4

Merge branch 'master' of https://github.com/ballerina-platform/baller…

2299e82

…ina-lang into new-typedesc # Conflicts: # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/types/JvmRecordTypeGen.java

github-actions bot added the Stale label Oct 17, 2023

chiranSachintha removed the Stale label Oct 18, 2023

github-actions bot added the Stale label Nov 2, 2023

github-actions bot closed this Nov 5, 2023

chiranSachintha removed the Stale label Nov 6, 2023

chiranSachintha reopened this Nov 6, 2023

github-actions bot added the Stale label Nov 21, 2023

chiranSachintha removed the Stale label Nov 23, 2023

chiranSachintha closed this Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate a typedesc instruction once for record and tuple types #39101

Generate a typedesc instruction once for record and tuple types #39101

chiranSachintha commented Dec 17, 2022 •

edited

Loading

MaryamZi Dec 21, 2022

chiranSachintha Jan 9, 2023 •

edited

Loading

MaryamZi Jan 10, 2023

chiranSachintha Jan 10, 2023

MaryamZi Jan 10, 2023

chiranSachintha Jan 10, 2023

MaryamZi Jan 10, 2023

MaryamZi Jan 17, 2023

MaryamZi Jan 19, 2023

MaryamZi Jan 19, 2023

MaryamZi Dec 21, 2022

chiranSachintha Jan 9, 2023 •

edited

Loading

codecov bot commented Jan 3, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023

github-actions bot commented Sep 17, 2023

github-actions bot commented Oct 17, 2023

github-actions bot commented Nov 2, 2023

github-actions bot commented Nov 5, 2023

github-actions bot commented Nov 21, 2023

chiranSachintha commented Jan 8, 2024

Generate a typedesc instruction once for record and tuple types #39101

Generate a typedesc instruction once for record and tuple types #39101

Conversation

chiranSachintha commented Dec 17, 2022 • edited Loading

Purpose

Check List

Choose a reason for hiding this comment

chiranSachintha Jan 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chiranSachintha Jan 9, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jan 3, 2023 • edited Loading

Codecov Report

github-actions bot commented Sep 13, 2023

github-actions bot commented Sep 17, 2023

github-actions bot commented Oct 17, 2023

github-actions bot commented Nov 2, 2023

github-actions bot commented Nov 5, 2023

github-actions bot commented Nov 21, 2023

chiranSachintha commented Jan 8, 2024

chiranSachintha commented Dec 17, 2022 •

edited

Loading

chiranSachintha Jan 9, 2023 •

edited

Loading

chiranSachintha Jan 9, 2023 •

edited

Loading

codecov bot commented Jan 3, 2023 •

edited

Loading