Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow annotations with mutable objects #40074

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

MaryamZi
Copy link
Member

@MaryamZi MaryamZi commented Apr 3, 2023

Purpose

$title. This was previously allowed because the std lib used such annotations.

Fixes #24246

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@MaryamZi MaryamZi added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Apr 3, 2023
@MaryamZi MaryamZi added this to the 2201.6.0 milestone Apr 3, 2023
@MaryamZi
Copy link
Member Author

MaryamZi commented Apr 3, 2023

Although ballerina-platform/ballerina-library#74 was fixed, seems like there are other mutable fields in HTTP annotations now - ballerina-platform/ballerina-library#4300.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +76.43% 🎉

Comparison is base (a9e9d76) 0.00% compared to head (1b110e2) 76.43%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40074       +/-   ##
=============================================
+ Coverage      0.00%   76.43%   +76.43%     
- Complexity        0    52411    +52411     
=============================================
  Files             9     2863     +2854     
  Lines            35   197347   +197312     
  Branches          0    25579    +25579     
=============================================
+ Hits              0   150839   +150839     
- Misses           35    38174    +38139     
- Partials          0     8334     +8334     
Files Changed Coverage Δ
...alang/compiler/semantics/analyzer/SymbolEnter.java 69.03% <100.00%> (ø)

... and 2861 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaryamZi MaryamZi removed this from the 2201.6.0 milestone Apr 17, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 2, 2023
@MaryamZi MaryamZi removed the Stale label May 3, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 18, 2023
@MaryamZi MaryamZi removed the Stale label May 19, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jun 3, 2023
@MaryamZi MaryamZi removed the Stale label Jun 4, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jun 19, 2023
@MaryamZi MaryamZi removed the Stale label Jun 20, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 5, 2023
@MaryamZi MaryamZi removed the Stale label Jul 6, 2023
Copy link
Member

@lochana-chathura lochana-chathura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@MaryamZi
Copy link
Member Author

Changing PR state to draft since stdlib needs to be fixed.

@MaryamZi MaryamZi marked this pull request as draft July 25, 2023 04:37
@MaryamZi MaryamZi added this to the 2201.8.0 milestone Jul 25, 2023
@MaryamZi MaryamZi marked this pull request as ready for review August 14, 2023 13:48
@MaryamZi MaryamZi merged commit 501a296 into ballerina-platform:master Aug 16, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable readonly object checks for annotation value
2 participants