-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow annotations with mutable objects #40074
Disallow annotations with mutable objects #40074
Conversation
Although ballerina-platform/ballerina-library#74 was fixed, seems like there are other mutable fields in HTTP annotations now - ballerina-platform/ballerina-library#4300. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #40074 +/- ##
=============================================
+ Coverage 0.00% 76.43% +76.43%
- Complexity 0 52411 +52411
=============================================
Files 9 2863 +2854
Lines 35 197347 +197312
Branches 0 25579 +25579
=============================================
+ Hits 0 150839 +150839
- Misses 35 38174 +38139
- Partials 0 8334 +8334
☔ View full report in Codecov by Sentry. |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
tests/jballerina-unit-test/src/test/resources/test-src/annotations/annots_with_invalid_type.bal
Show resolved
Hide resolved
Changing PR state to draft since stdlib needs to be fixed. |
Purpose
$title. This was previously allowed because the std lib used such annotations.
Fixes #24246
Check List