Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaultable error message when an invalid named argument is used #43440

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

areebniyas
Copy link
Contributor

Purpose

$subject

Fixes #25230

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (c61fc38) to head (d036b9f).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...apter/evaluation/engine/NodeBasedArgProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43440      +/-   ##
============================================
- Coverage     77.50%   77.50%   -0.01%     
+ Complexity    58596    58594       -2     
============================================
  Files          3438     3438              
  Lines        219259   219259              
  Branches      28924    28924              
============================================
- Hits         169938   169935       -3     
- Misses        39902    39903       +1     
- Partials       9419     9421       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gimantha
gimantha previously approved these changes Oct 4, 2024
@gimantha gimantha dismissed their stale review October 4, 2024 05:09

Still reviewing some edge cases

@gimantha gimantha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Oct 4, 2024
@gimantha gimantha merged commit f436157 into ballerina-platform:master Oct 4, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the error when an invalid named argument is used
3 participants