Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make basic auth providers isolated #209

Merged
merged 3 commits into from
May 21, 2021

Conversation

ldclakmal
Copy link
Member

Purpose

$subject
Related to ballerina-platform/ballerina-library#584

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #209 (49fb8c0) into master (80ab270) will decrease coverage by 0.49%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #209      +/-   ##
============================================
- Coverage     81.87%   81.37%   -0.50%     
  Complexity       94       94              
============================================
  Files            17       17              
  Lines           491      494       +3     
  Branches         80       82       +2     
============================================
  Hits            402      402              
- Misses           69       72       +3     
  Partials         20       20              
Impacted Files Coverage Δ Complexity Δ
...a/listener_ldap_user_store_basic_auth_provider.bal 82.85% <50.00%> (-5.03%) 0.00 <0.00> (ø)
auth-ballerina/client_basic_auth_provider.bal 90.00% <66.66%> (-10.00%) 0.00 <0.00> (ø)
...a/listener_file_user_store_basic_auth_provider.bal 95.45% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ab270...49fb8c0. Read the comment docs.

@ldclakmal ldclakmal merged commit 7978b99 into ballerina-platform:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants