Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security to FTP #276

Merged
merged 15 commits into from
Jun 14, 2021
Merged

Add security to FTP #276

merged 15 commits into from
Jun 14, 2021

Conversation

Maninda
Copy link
Member

@Maninda Maninda commented Jun 9, 2021

Purpose

Resolves ballerina-platform/ballerina-library#1438

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@Maninda Maninda self-assigned this Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #276 (a6c9d4a) into master (13e4249) will increase coverage by 3.13%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
+ Coverage     73.50%   76.64%   +3.13%     
- Complexity       67       70       +3     
============================================
  Files            18       18              
  Lines           785      762      -23     
  Branches        125      120       -5     
============================================
+ Hits            577      584       +7     
+ Misses          181      155      -26     
+ Partials         27       23       -4     
Impacted Files Coverage Δ
ftp-ballerina/commons.bal 100.00% <ø> (+45.00%) ⬆️
...rg/ballerinalang/stdlib/ftp/util/FTPConstants.java 100.00% <ø> (ø)
ftp-ballerina/client_endpoint.bal 95.83% <50.00%> (-0.09%) ⬇️
...org/ballerinalang/stdlib/ftp/client/FTPClient.java 76.92% <61.53%> (+3.38%) ⬆️
...ava/org/ballerinalang/stdlib/ftp/util/FTPUtil.java 58.22% <66.66%> (+0.72%) ⬆️
...erinalang/stdlib/ftp/server/FTPListenerHelper.java 79.06% <75.00%> (+17.70%) ⬆️
ftp-ballerina/external_functions.bal 85.71% <100.00%> (ø)
ftp-ballerina/listener_endpoint.bal 85.18% <100.00%> (-1.03%) ⬇️
...g/ballerinalang/stdlib/ftp/server/FTPListener.java 81.08% <0.00%> (+5.40%) ⬆️
...erinalang/stdlib/ftp/client/FTPClientListener.java 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e4249...a6c9d4a. Read the comment docs.

@Maninda Maninda marked this pull request as ready for review June 11, 2021 07:20
@Maninda Maninda requested a review from ldclakmal June 11, 2021 07:21
@ldclakmal ldclakmal requested a review from praneesha June 12, 2021 02:26
@Maninda Maninda merged commit ee3bef7 into master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Security for FTP
4 participants