Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory structure and package names #316

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Update directory structure and package names #316

merged 3 commits into from
Jul 9, 2021

Conversation

Maninda
Copy link
Member

@Maninda Maninda commented Jul 9, 2021

Purpose

$subject related to ballerina-platform/ballerina-library#1623

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@Maninda Maninda self-assigned this Jul 9, 2021
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #316 (be55c8e) into master (b8473d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #316   +/-   ##
=========================================
  Coverage     84.89%   84.89%           
  Complexity       84       84           
=========================================
  Files            17       17           
  Lines           768      768           
  Branches        108      108           
=========================================
  Hits            652      652           
  Misses           92       92           
  Partials         24       24           
Impacted Files Coverage Δ
ballerina/byte_stream.bal 89.47% <ø> (ø)
ballerina/client_endpoint.bal 95.00% <ø> (ø)
ballerina/commons.bal 100.00% <ø> (ø)
ballerina/external_functions.bal 85.71% <ø> (ø)
ballerina/file_event.bal 100.00% <ø> (ø)
ballerina/init.bal 100.00% <ø> (ø)
ballerina/listener_endpoint.bal 88.88% <ø> (ø)
...java/io/ballerina/stdlib/ftp/client/FtpClient.java 83.12% <ø> (ø)
...o/ballerina/stdlib/ftp/client/FtpClientHelper.java 82.95% <ø> (ø)
...ballerina/stdlib/ftp/client/FtpClientListener.java 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8473d6...be55c8e. Read the comment docs.

@Maninda Maninda marked this pull request as ready for review July 9, 2021 07:08
@Maninda Maninda requested a review from ThisaruGuruge July 9, 2021 07:09
@Maninda Maninda merged commit 23f25ca into master Jul 9, 2021
@niveathika
Copy link
Contributor

niveathika commented Jul 12, 2021

@ThisaruGuruge
Copy link
Member

@Maninda @ThisaruGuruge Seems FTP is still published under 'org.ballerinalang' group id

https://github.com/orgs/ballerina-platform/packages?repo_name=module-ballerina-ftp

https://github.com/ballerina-platform/module-ballerina-ftp/blob/master/build.gradle#L50 This line seems to be the issue

I was under the impression that it is already using project.gradle variable here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants