Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC compiler plugin #154

Merged
merged 59 commits into from
Apr 9, 2021
Merged

Add gRPC compiler plugin #154

merged 59 commits into from
Apr 9, 2021

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

Fixes ballerina-platform/ballerina-library#814

Automation tests

  • Unit tests

    Yes

Test environment

  • macOS
  • Java 11
  • SLAlpha 3 and 4

BuddhiWathsala and others added 26 commits March 22, 2021 15:00
@BuddhiWathsala
Replace grpc:EOS->grpc:EosError in the implementation
f95666d
@BuddhiWathsala
Replace grpc:EOS->grpc:EosError in the tests
2146f7f
@BuddhiWathsala
Replace grpc:EOS->grpc:EosError in Package.md
06b3ad8
@BuddhiWathsala
Add gRPC compiler plugin configurations
9f23ca6
@BuddhiWathsala
Add phase 01 service validation for compiler plugin
20d81d3
@BuddhiWathsala
Add a doc for compiler plugin
4e8969b
@BuddhiWathsala
Add CompilerPlugin.toml
8e1c0f2
@daneshk
Update the branch with upstream branch
300ec0c
@daneshk
Add compiler plugins
6a49220
@BuddhiWathsala
Add remote method validations in compiler plugin
3ec20ac
@daneshk
Add compiler plugin test module
da42d4e
@daneshk
Add compiler plugin test module
6e21a9c
@daneshk
Merge branch 'bdev' into bdev
f1dc64a
@daneshk
remove git ignore files from test packages
35aee3b
@daneshk
Merge pull request #145 from daneshk/bdev
50f07ff 
Add compiler plugin test module
@BuddhiWathsala
Improve the Gradle configurations for the compiler plugin
dcc8ebc
@BuddhiWathsala
Add parameterised CompilerPlugin.toml
bc3b4e1
@BuddhiWathsala
Add gRPC remote function validation check
fbcf074
@BuddhiWathsala
Fix compiler plugin checkstyle issues
e07cb49
@BuddhiWathsala
Merge remote-tracking branch 'origin/master' into bdev1
34a7c74
@BuddhiWathsala
Merge pull request #150 from ballerina-platform/bdev1
b73bbf6 
Fix the Gradle configs and add remote function check
@BuddhiWathsala
Merge remote-tracking branch 'origin' into bdev1
03b44cf
@BuddhiWathsala
Fix the checkstyle configurations
2b03fdb
@BuddhiWathsala
Add Java docs for compiler tests
76ed12f
@BuddhiWathsala
Improve the compiler plugin to validate input parameters
a0c6bf2
@BuddhiWathsala
Merge pull request #153 from ballerina-platform/bdev1
3381781 
Add input type validations
@BuddhiWathsala BuddhiWathsala marked this pull request as draft April 1, 2021 09:37
@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #154 (609e26b) into master (ad6333c) will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
+ Coverage     39.44%   40.41%   +0.97%     
  Complexity      572      572              
============================================
  Files           115      113       -2     
  Lines          6110     5963     -147     
  Branches       1108     1083      -25     
============================================
  Hits           2410     2410              
+ Misses         3342     3195     -147     
  Partials        358      358
Impacted Files Coverage Δ Complexity Δ
...allerinalang/net/grpc/ClientConnectorListener.java 43.70% <ø> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6333c...609e26b. Read the comment docs.

@BuddhiWathsala BuddhiWathsala requested a review from daneshk April 1, 2021 09:48
@BuddhiWathsala
Fix the settings.gradle
3b6980d
@BuddhiWathsala
Add Gradle configurations to build native code before compiler plugin
0564bbd 
Because compiler plugin needs MessageUtils.getCallerTypeName() API to get the caller name.
@BuddhiWathsala
Import native JAR to the compiler plugin
5d0405e
@BuddhiWathsala
Enable caller validation in the compiler plugin
2036a90
@BuddhiWathsala
Enable caller validation compiler plugin test
87178fb
@BuddhiWathsala
Merge remote-tracking branch 'origin/master' into bdev1
b5d1ffb
@BuddhiWathsala
Merge remote-tracking branch 'origin/master' into bdev1
9011d24
@BuddhiWathsala
Fix the typeName class cast exception
2908a3f
@BuddhiWathsala
Disabled the annotation test
96fc496 
Due to this issue ballerina-platform/ballerina-lang#29919
@BuddhiWathsala
Merge pull request #158 from ballerina-platform/bdev1
53fe10b 
Improve the compiler plugin to filter the gRPC package services
@BuddhiWathsala
Remove unnecessary older compiler plugin implementation
127e5a6 
To solve this issue ballerina-platform/ballerina-lang#29919
@BuddhiWathsala
Improve the compiler plugin annotation tests by adding multiple services
286fbf4
@BuddhiWathsala
Enable the compiler plugin annotation test
4cdbfcf
@BuddhiWathsala
Merge pull request #171 from ballerina-platform/bdev1
d915a69 
Fix the annotations test
@BuddhiWathsala
Improve the compiler plugin to check package aliases
ab4b35a
@BuddhiWathsala
Add tests to cover compiler plugin with package aliases
49ebfef
@BuddhiWathsala
Merge pull request #172 from ballerina-platform/bdev1
553f617 
Improve the compiler plugin to check package aliases
@BuddhiWathsala BuddhiWathsala requested review from daneshk and removed request for daneshk April 8, 2021 09:58
@BuddhiWathsala BuddhiWathsala marked this pull request as ready for review April 8, 2021 10:01
@BuddhiWathsala BuddhiWathsala requested a review from pubudu91 April 8, 2021 10:31
@BuddhiWathsala
Remove the unnecessary EosError error
0203e25 
Currently, the end-of-stream is indicated using nil.
@BuddhiWathsala
Add missing tailing line
ab09567
daneshk
daneshk approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BuddhiWathsala BuddhiWathsala merged commit f0c5af1 into master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daneshk daneshk daneshk approved these changes

@pubudu91 pubudu91 Awaiting requested review from pubudu91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a new compiler plugin to validate new service syntax
2 participants
@BuddhiWathsala @daneshk