Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the start and stop logs of the listener #539

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

Related to ballerina-platform/ballerina-library#2040
Support it only in debug mode.

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

Support it only in the debug mode.
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #539 (34c0b4c) into master (5fbf543) will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #539      +/-   ##
============================================
+ Coverage     81.24%   81.27%   +0.02%     
  Complexity       24       24              
============================================
  Files           127      126       -1     
  Lines          7374     7363      -11     
  Branches       1336     1335       -1     
============================================
- Hits           5991     5984       -7     
+ Misses          925      919       -6     
- Partials        458      460       +2     
Impacted Files Coverage Δ
...tdlib/grpc/ServerConnectorPortBindingListener.java 33.33% <0.00%> (-38.10%) ⬇️
...b/grpc/callback/StreamingCallableUnitCallBack.java 83.13% <50.00%> (ø)
...tdlib/grpc/callback/UnaryCallableUnitCallBack.java 80.68% <50.00%> (ø)
...lerina/stdlib/grpc/listener/ServerCallHandler.java 79.31% <50.00%> (ø)
...dlib/grpc/listener/StreamingServerCallHandler.java 85.71% <50.00%> (ø)
...stdlib/grpc/ObservableClientConnectorListener.java 85.00% <0.00%> (-5.00%) ⬇️
../ballerina/
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e234e...34c0b4c. Read the comment docs.

@BuddhiWathsala BuddhiWathsala merged commit 70b3f81 into master Nov 16, 2021
@BuddhiWathsala BuddhiWathsala deleted the depen branch December 20, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants