[2201.5.x] Fix overwriting the Host header #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 35ad764)
TharmiganK
force-pushed
the
host-header-fix-2201.5.x
branch
from
ccb3eae
to
7a479ba
Compare
TharmiganK
commented
Mar 5, 2024
ballerina-tests/http2-tests/tests/http2_service_dispatching_header_param_binding_test.bal
Outdated
Show resolved
Hide resolved
|
lnash94
reviewed
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2201.5.x #1881 +/- ##
==============================================
+ Coverage 81.54% 81.57% +0.02%
Complexity 524 524
==============================================
Files 388 388
Lines 21064 21064
Branches 4702 4703 +1
==============================================
+ Hits 17176 17182 +6
+ Misses 2904 2901 -3
+ Partials 984 981 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Note: With this improvement users can override the
Hostheader, but this does not change the connection internals. We will still connect to the endpoint defined in the clientURLbut theHostheader send in the request can be overridable. This is in line with the cURL client.For HTTP/2, we expose the
Hostheader from the pseudo header. Since the pseudo header exposure is added from2201.7.x, we cannot add test with HTTP/2 in2201.5.x. For the sake of completeness, I have back ported the pseudo headers fix with this PRExamples
N/A
Checklist
Updated the spec