-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign HTTP listener/client SecureSocket API #255
Merged
ldclakmal
merged 8 commits into
ballerina-platform:master
from
ldclakmal:dev-securesocket
Mar 8, 2021
Merged
Redesign HTTP listener/client SecureSocket API #255
ldclakmal
merged 8 commits into
ballerina-platform:master
from
ldclakmal:dev-securesocket
Mar 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldclakmal
force-pushed
the
dev-securesocket
branch
from
March 5, 2021 13:47
cdef301
to
3b073c9
Compare
ldclakmal
force-pushed
the
dev-securesocket
branch
from
March 6, 2021 02:45
3b073c9
to
b0e440d
Compare
Bhashinee
reviewed
Mar 8, 2021
ldclakmal
commented
Mar 8, 2021
Co-authored-by: Bhashinee <Bhashinee@users.noreply.github.com>
Bhashinee
reviewed
Mar 8, 2021
http-native/src/main/java/org/ballerinalang/net/http/HttpUtil.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
=============================================
- Coverage 63.80% 50.00% -13.81%
Complexity 62 62
=============================================
Files 327 377 +50
Lines 14552 18506 +3954
Branches 1655 3538 +1883
=============================================
- Hits 9285 9253 -32
- Misses 4511 8512 +4001
+ Partials 756 741 -15
Continue to review full report at Codecov.
|
Bhashinee
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR redesign the HTTP listener/client
SecureSocket
API for SwanLake release. The updated API would be as follows:Listener
Client
Fixes ballerina-platform/ballerina-library#917
Related to ballerina-platform/ballerina-library#584