Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for OS command execution #438

Merged
merged 27 commits into from
Jul 8, 2022

Conversation

madhukaw
Copy link
Contributor

@madhukaw madhukaw commented Jul 6, 2022

Purpose

Fixes ballerina-platform/ballerina-library#2852

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@madhukaw madhukaw requested a review from daneshk as a code owner July 6, 2022 11:26
@madhukaw madhukaw marked this pull request as draft July 6, 2022 11:26
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #438 (d1239d3) into master (64ad02b) will increase coverage by 1.58%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##             master     #438      +/-   ##
============================================
+ Coverage     82.92%   84.50%   +1.58%     
- Complexity       13       25      +12     
============================================
  Files             9       15       +6     
  Lines            82      142      +60     
  Branches         23       35      +12     
============================================
+ Hits             68      120      +52     
- Misses           13       20       +7     
- Partials          1        2       +1     
Impacted Files Coverage Δ
...io/ballerina/stdlib/os/nativeimpl/WaitForExit.java 40.00% <40.00%> (ø)
...java/io/ballerina/stdlib/os/nativeimpl/Output.java 78.94% <78.94%> (ø)
...n/java/io/ballerina/stdlib/os/nativeimpl/Exec.java 91.66% <91.66%> (ø)
ballerina/os.bal 100.00% <100.00%> (ø)
ballerina/process.bal 100.00% <100.00%> (ø)
...java/io/ballerina/stdlib/os/nativeimpl/Errors.java 100.00% <100.00%> (ø)
...n/java/io/ballerina/stdlib/os/nativeimpl/Exit.java 100.00% <100.00%> (ø)
...ain/java/io/ballerina/stdlib/os/utils/OSUtils.java 90.00% <100.00%> (-10.00%) ⬇️
...io/ballerina/stdlib/os/nativeimpl/ModuleUtils.java 100.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ad02b...d1239d3. Read the comment docs.

@madhukaw madhukaw marked this pull request as ready for review July 7, 2022 04:34
@madhukaw madhukaw changed the title Introduce os:exec function Introduce support for OS command execution Jul 7, 2022
ballerina/os.bal Outdated Show resolved Hide resolved
ballerina/process.bal Outdated Show resolved Hide resolved
docs/spec/spec.md Outdated Show resolved Hide resolved
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhukaw madhukaw merged commit 89e066a into ballerina-platform:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce OS command execution support in Ballerina
3 participants