-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement declarative auth design for upgrade service #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allerina-websocket into dev-chanakal # Conflicts: # websocket-ballerina/tests/websocket_ssl_proxy.bal
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
============================================
- Coverage 80.91% 80.60% -0.31%
- Complexity 346 349 +3
============================================
Files 43 44 +1
Lines 1991 2083 +92
Branches 271 311 +40
============================================
+ Hits 1611 1679 +68
- Misses 297 317 +20
- Partials 83 87 +4
Continue to review full report at Codecov.
|
Bhashinee
reviewed
Jun 11, 2021
Bhashinee
reviewed
Jun 11, 2021
websocket-native/src/main/java/org/ballerinalang/net/websocket/WebSocketUtil.java
Outdated
Show resolved
Hide resolved
Bhashinee
approved these changes
Jun 11, 2021
Co-authored-by: Bhashinee <Bhashinee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces the declarative auth design for WebSocket listener.
Design: https://docs.google.com/document/d/1dGw5uUP6kqZNTwMfQ_Ik-k0HTMKhX70XpEA3tys9_kk/edit?usp=sharing
Example:
Fixes ballerina-platform/ballerina-library#1405
Fixes ballerina-platform/ballerina-library#1230
Related to: ballerina-platform/ballerina-library#584
Checklist