-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed websites company tab data #2449
Conversation
|
WalkthroughThe recent updates enhance the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as User Interface
participant Adapter as Report Adapter
participant Component as WebsiteLineOfBusiness
User->>UI: Load Business Report
UI->>Adapter: Fetch Report Data
Adapter->>UI: Return Report Data with indicators (label, url)
UI->>Component: Render with description (lineOfBusinessDescription)
Component-->>User: Display Business Report
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- apps/backoffice-v2/src/domains/business-reports/adapters/report-adapter/report-adapter.ts (2 hunks)
- apps/backoffice-v2/src/domains/business-reports/components/WebsiteLineOfBusiness/WebsiteLineOfBusiness.tsx (2 hunks)
- apps/backoffice-v2/src/domains/business-reports/components/WebsitesCompany/WebsitesCompany.tsx (2 hunks)
- apps/backoffice-v2/src/lib/blocks/variants/WebsiteMonitoringBlocks/hooks/useWebsiteMonitoringReportBlock/hooks/useWebsiteMonitoringBusinessReportTab/useWebsiteMonitoringBusinessReportTab.tsx (1 hunks)
- apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx (1 hunks)
Files skipped from review due to trivial changes (2)
- apps/backoffice-v2/src/domains/business-reports/components/WebsiteLineOfBusiness/WebsiteLineOfBusiness.tsx
- apps/backoffice-v2/src/lib/blocks/variants/WebsiteMonitoringBlocks/hooks/useWebsiteMonitoringReportBlock/hooks/useWebsiteMonitoringBusinessReportTab/useWebsiteMonitoringBusinessReportTab.tsx
Additional comments not posted (3)
apps/backoffice-v2/src/domains/business-reports/components/WebsitesCompany/WebsitesCompany.tsx (1)
Line range hint
7-38
: The changes inWebsitesCompany.tsx
correctly handle the new structure ofcompanyReputationAnalysis
. The use ofBallerineLink
for URLs is appropriate and enhances user interaction by providing direct links.apps/backoffice-v2/src/domains/business-reports/adapters/report-adapter/report-adapter.ts (1)
93-95
: The modifications inreportAdapter
to includelabel
andurl
properties inscamOrFraud.indicators
are correctly implemented. This change enhances the data structure and is consistent with the PR objectives.Also applies to: 189-191
apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx (1)
125-125
: The update fromsummary
todescription
in theMerchantMonitoringBusinessReport
page is correctly implemented and consistent with similar changes in other components.
Summary by CodeRabbit
New Features
scamOrFraud.indicators
withlabel
andurl
properties for improved reporting.Refactor
summary
prop todescription
inWebsiteLineOfBusiness
component for better clarity.companyReputationAnalysis
inWebsitesCompany
component to an array of objects withlabel
andurl
properties for more detailed analysis.Bug Fixes
description
prop, ensuring consistent data display across the application.