Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed websites company tab data #2449

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Omri-Levy
Copy link
Contributor

@Omri-Levy Omri-Levy commented Jun 11, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced scamOrFraud.indicators with label and url properties for improved reporting.
  • Refactor

    • Renamed summary prop to description in WebsiteLineOfBusiness component for better clarity.
    • Updated companyReputationAnalysis in WebsitesCompany component to an array of objects with label and url properties for more detailed analysis.
  • Bug Fixes

    • Adjusted components and hooks to use the new description prop, ensuring consistent data display across the application.

Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: efdbe86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 11, 2024

Walkthrough

The recent updates enhance the backoffice-v2 application by refining data structures and renaming properties for clarity. Key changes include transforming scamOrFraud.indicators to include label and url properties, renaming the summary prop to description in several components, and updating the companyReputationAnalysis prop to handle objects with label and url.

Changes

File Path Change Summary
.../report-adapter/report-adapter.ts Updated scamOrFraud.indicators to include label and url properties.
.../components/WebsiteLineOfBusiness/WebsiteLineOfBusiness.tsx Renamed summary prop to description.
.../components/WebsitesCompany/WebsitesCompany.tsx Updated companyReputationAnalysis to be an array of objects with label and url properties.
.../hooks/useWebsiteMonitoringReportBlock/.../useWebsiteMonitoringBusinessReportTab.tsx Changed summary prop to description when passed to WebsiteLineOfBusiness component.
.../pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx Changed summary prop to description when passed to WebsiteLineOfBusiness component.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI as User Interface
    participant Adapter as Report Adapter
    participant Component as WebsiteLineOfBusiness

    User->>UI: Load Business Report
    UI->>Adapter: Fetch Report Data
    Adapter->>UI: Return Report Data with indicators (label, url)
    UI->>Component: Render with description (lineOfBusinessDescription)
    Component-->>User: Display Business Report
Loading

Poem

In the code where data flows,
New labels and URLs arose,
Description now takes summary's place,
Enhancing clarity, adding grace.
With each tweak, the system grows,
A rabbit's joy in every prose. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 053dc47 and efdbe86.

Files selected for processing (5)
  • apps/backoffice-v2/src/domains/business-reports/adapters/report-adapter/report-adapter.ts (2 hunks)
  • apps/backoffice-v2/src/domains/business-reports/components/WebsiteLineOfBusiness/WebsiteLineOfBusiness.tsx (2 hunks)
  • apps/backoffice-v2/src/domains/business-reports/components/WebsitesCompany/WebsitesCompany.tsx (2 hunks)
  • apps/backoffice-v2/src/lib/blocks/variants/WebsiteMonitoringBlocks/hooks/useWebsiteMonitoringReportBlock/hooks/useWebsiteMonitoringBusinessReportTab/useWebsiteMonitoringBusinessReportTab.tsx (1 hunks)
  • apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx (1 hunks)
Files skipped from review due to trivial changes (2)
  • apps/backoffice-v2/src/domains/business-reports/components/WebsiteLineOfBusiness/WebsiteLineOfBusiness.tsx
  • apps/backoffice-v2/src/lib/blocks/variants/WebsiteMonitoringBlocks/hooks/useWebsiteMonitoringReportBlock/hooks/useWebsiteMonitoringBusinessReportTab/useWebsiteMonitoringBusinessReportTab.tsx
Additional comments not posted (3)
apps/backoffice-v2/src/domains/business-reports/components/WebsitesCompany/WebsitesCompany.tsx (1)

Line range hint 7-38: The changes in WebsitesCompany.tsx correctly handle the new structure of companyReputationAnalysis. The use of BallerineLink for URLs is appropriate and enhances user interaction by providing direct links.

apps/backoffice-v2/src/domains/business-reports/adapters/report-adapter/report-adapter.ts (1)

93-95: The modifications in reportAdapter to include label and url properties in scamOrFraud.indicators are correctly implemented. This change enhances the data structure and is consistent with the PR objectives.

Also applies to: 189-191

apps/backoffice-v2/src/pages/MerchantMonitoringBusinessReport/MerchantMonitoringBusinessReport.page.tsx (1)

125-125: The update from summary to description in the MerchantMonitoringBusinessReport page is correctly implemented and consistent with similar changes in other components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants