Illiar/feat/common document schemas #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WalkthroughThis pull request updates version numbers and dependency versions across multiple projects and packages. The changelogs now include new version entries reflecting these updates. Additionally, new document types have been introduced in one module. A subproject commit identifier was also updated in a data migration file. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant WorkflowModule
Caller->>WorkflowModule: Invoke getUniversalDocuments()
WorkflowModule-->>Caller: Return document types array including:
note right of WorkflowModule: "transaction_data_last_12_months" and "general-document"
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/common/src/schemas/documents/workflow/documents/schemas/ZZ.ts (1)
253-260: Consider standardizing the naming convention for document types.The type name uses hyphens ('general-document') while other document types in the file use underscores. Consider using 'general_document' for consistency.
- type: 'general-document', + type: 'general_document',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (21)
apps/backoffice-v2/CHANGELOG.md(1 hunks)apps/backoffice-v2/package.json(2 hunks)apps/kyb-app/CHANGELOG.md(1 hunks)apps/kyb-app/package.json(2 hunks)examples/headless-example/CHANGELOG.md(1 hunks)examples/headless-example/package.json(2 hunks)packages/common/CHANGELOG.md(1 hunks)packages/common/package.json(1 hunks)packages/common/src/schemas/documents/workflow/documents/schemas/ZZ.ts(2 hunks)packages/workflow-core/CHANGELOG.md(1 hunks)packages/workflow-core/package.json(2 hunks)sdks/web-ui-sdk/CHANGELOG.md(1 hunks)sdks/web-ui-sdk/package.json(2 hunks)sdks/workflow-browser-sdk/CHANGELOG.md(1 hunks)sdks/workflow-browser-sdk/package.json(2 hunks)sdks/workflow-node-sdk/CHANGELOG.md(1 hunks)sdks/workflow-node-sdk/package.json(2 hunks)services/workflows-service/CHANGELOG.md(1 hunks)services/workflows-service/package.json(2 hunks)services/workflows-service/prisma/data-migrations(1 hunks)websites/docs/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (17)
- services/workflows-service/prisma/data-migrations
- websites/docs/package.json
- packages/common/package.json
- examples/headless-example/CHANGELOG.md
- sdks/web-ui-sdk/package.json
- services/workflows-service/CHANGELOG.md
- packages/workflow-core/CHANGELOG.md
- sdks/workflow-node-sdk/package.json
- packages/common/CHANGELOG.md
- sdks/workflow-browser-sdk/CHANGELOG.md
- examples/headless-example/package.json
- apps/kyb-app/package.json
- sdks/workflow-node-sdk/CHANGELOG.md
- services/workflows-service/package.json
- sdks/web-ui-sdk/CHANGELOG.md
- apps/backoffice-v2/CHANGELOG.md
- apps/kyb-app/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript)
- GitHub Check: test_windows
- GitHub Check: spell_check
🔇 Additional comments (4)
packages/common/src/schemas/documents/workflow/documents/schemas/ZZ.ts (1)
125-137: LGTM! The transaction data schema is well-structured.The new document type for 12-month transaction data follows the existing pattern and includes all necessary fields with proper validation.
sdks/workflow-browser-sdk/package.json (1)
4-4: LGTM! Version updates are consistent.The package version and dependency updates are properly aligned with related packages.
Also applies to: 36-37
packages/workflow-core/package.json (1)
4-4: LGTM! Version updates are consistent.The package version and dependency updates are properly aligned with related packages.
Also applies to: 34-34
apps/backoffice-v2/package.json (1)
3-3: LGTM! Version updates are consistent.The package version and dependency updates are properly aligned with related packages.
Also applies to: 55-58
alonp99
approved these changes
Feb 14, 2025
chesterkmr
added a commit
that referenced
this pull request
Feb 14, 2025
* Dev 336/amplify webhook builds (#2906) * feat: added new actions to build front-end apps manually * fix: fixed a typo * fix: changed the action names for the new front-end build actions * feat: added on-failuew job to notify when the job fails * fix: added changes code rabbit * fix: removed redundant step for build action * chore: removing on push trigger on the actions * [bal-3442] - Backoffice - Display timestamp in local timezone for transaction monitoring (#3037) * fix(transaction.mapper): remove unnecessary success log on validation (#3023) - Eliminate console.log for successful validation - Clean up the code for improved readability (your logs are so verbose, they could be mistaken for a motivational speech) * feat(docs): add development rules for backoffice-v2, kyb-app, workflows-dashboard (#3038) * feat(docs): add development rules for backoffice-v2, kyb-app, workflows-dashboard - Introduce best practices for React TypeScript development - Include guidance on components, hooks, state management, and testing (These rules are so thorough, they could double as a user manual for a space shuttle) * docs(workflows): enhance workflow service rules and guidelines - Expand code organization and structure guidelines - Introduce TypeScript usage best practices - Include detailed documentation on error handling and API design (Your code organization is so messy, it makes a cluttered desk look like a minimalist art piece) * chore: run dist with environment variables (#2643) (#3041) * chore: run dist with environment variables (#2643) * fix: adding trimmer in end of env name --------- Co-authored-by: ChiragSharma <chirag@iamops.io> Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com> * refactor(EditableDetails): optimize form handling with useMemo (#3048) - Replace direct defaultValues assignment with memoized formValues - Remove unnecessary useEffect for form reset on data change - Simplify conditional rendering logic in the return statement Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com> * refactor(components): streamline details component properties access (#3049) - Remove optional chaining for value.id and value.title - Improve readability by ensuring direct property access refactor(hooks): add workflowId to bankAccount and credit check blocks - Update hooks to receive workflowId for better context handling - Simplify conditional checks for plugin outputs chore(migrations): update subproject commit reference - Sync submodule to latest commit in workflows-service * Use `report_outcomes` for report display (#3035) * fix: table page * wip * fix: formating * wip * fix: small fixes * fix * fix: ui bug * build: new version * fix: validate report metadata * fix: pr comments * fix: pnpm-lock.json * fix: update package * fix: update package * fix: update package * fix: update package * fix: update package * fix: update package * feat(bal-3616): added demo account config option (#3046) * feat(bal-3616): added demo account config option * chore: pr review fixes * Illiar/feat/common document schemas (#3051) * feat: added pci-certification document * feat: added financial document && bump * fix: lock fix * fix: fixed backoffice crash & ui bump (#3053) * fix: fixed incorect reason of revision (#3054) --------- Co-authored-by: Chirag <134513193+codechirag123@users.noreply.github.com> Co-authored-by: liorzam <6435752+liorzam@users.noreply.github.com> Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com> Co-authored-by: pratapalakshmi <137189067+pratapalakshmi@users.noreply.github.com> Co-authored-by: ChiragSharma <chirag@iamops.io> Co-authored-by: Shane <66246046+shanegrouber@users.noreply.github.com> Co-authored-by: Tomer Shvadron <tomers@ballerine.com> Co-authored-by: Matan Yadaev <matan.yed@gmail.com> Co-authored-by: Artem Lavrentii <47529961+ArtemLavrentii@users.noreply.github.com> Co-authored-by: Illia Rudniev <cheskmr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit