-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
55 add support for expo sdk 50 #58
Conversation
🦋 Changeset detectedLatest commit: b7a7df5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9491575 | Triggered | Google API Key | b054472 | example/android/app/src/main/AndroidManifest.xml | View secret |
9491575 | Triggered | Google API Key | 2d0cc2a | example/android/app/src/main/AndroidManifest.xml | View secret |
9491575 | Triggered | Google API Key | 523f955 | example/android/app/src/main/AndroidManifest.xml | View secret |
9491575 | Triggered | Google API Key | b7a7df5 | example/android/app/src/main/AndroidManifest.xml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
WalkthroughThis update involves a minor yet significant adjustment to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
example/android/app/src/main/AndroidManifest.xml
is excluded by:!**/*.xml
Files selected for processing (1)
- .changeset/old-waves-wave.md (1 hunks)
"@balloman/expo-google-maps": patch | ||
--- | ||
|
||
Remove key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description "Remove key" is too vague. Consider specifying which key was removed and the reason for its removal to provide better context for the change.
Summary by CodeRabbit
@balloman/expo-google-maps
to enhance security by removing a redundant key.