Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

55 add support for expo sdk 50 #58

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

balloman
Copy link
Owner

@balloman balloman commented Feb 8, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Patched @balloman/expo-google-maps to enhance security by removing a redundant key.

Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: b7a7df5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@balloman/expo-google-maps Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

gitguardian bot commented Feb 8, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9491575 Triggered Google API Key b054472 example/android/app/src/main/AndroidManifest.xml View secret
9491575 Triggered Google API Key 2d0cc2a example/android/app/src/main/AndroidManifest.xml View secret
9491575 Triggered Google API Key 523f955 example/android/app/src/main/AndroidManifest.xml View secret
9491575 Triggered Google API Key b7a7df5 example/android/app/src/main/AndroidManifest.xml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

coderabbitai bot commented Feb 8, 2024

Walkthrough

This update involves a minor yet significant adjustment to the @balloman/expo-google-maps package. The change is focused on enhancing security and performance by removing an unnecessary key from the package configuration. This patch ensures that the package remains streamlined and efficient, contributing to a better user experience and overall application stability.

Changes

Files Changed Summary
.changeset/old-waves-wave.md Removed a key from @balloman/expo-google-maps package

🐰✨
In the digital fields where code does roam,
A tiny key was sent back home.
With each hop and leap, we refine,
Crafting code that's simply divine.
🚀🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@balloman balloman merged commit 20cc98b into main Feb 8, 2024
2 of 3 checks passed
@balloman balloman deleted the 55-add-support-for-expo-sdk-50 branch February 8, 2024 06:41
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 46dd4d9 and b7a7df5.
Files ignored due to path filters (1)
  • example/android/app/src/main/AndroidManifest.xml is excluded by: !**/*.xml
Files selected for processing (1)
  • .changeset/old-waves-wave.md (1 hunks)

"@balloman/expo-google-maps": patch
---

Remove key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Remove key" is too vague. Consider specifying which key was removed and the reason for its removal to provide better context for the change.

@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant