Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(modal): wrong postion with angular 17 and build optimzer #1389

Closed
1 task done
hirsch88 opened this issue Apr 29, 2024 · 2 comments · Fixed by #1390
Closed
1 task done

🐛 fix(modal): wrong postion with angular 17 and build optimzer #1389

hirsch88 opened this issue Apr 29, 2024 · 2 comments · Fixed by #1390
Assignees
@hirsch88
Labels
🐛 bug Something isn't working

Comments

@hirsch88
Copy link
Member

Current Behavior

toast and snacker are displayed at the bottom of the page

Expected Behavior

bal-novice component should be defined and set the correct postion

Steps to Reproduce

Version

latest

Browsers

No response

Device

No response

Code Reproduction URL

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hirsch88 hirsch88 added the 🐛 bug Something isn't working label Apr 29, 2024
@hirsch88 hirsch88 self-assigned this Apr 29, 2024
@hirsch88
Copy link
Member Author

/cib

@github-actions GitHub Actions
Copy link
Contributor

Branch fix/issue-1389 created!

github-actions bot added a commit that referenced this issue Apr 29, 2024
@github-actions
Create PR for #1389
be042f7
@github-actions github-actions bot mentioned this issue Apr 29, 2024
Merged
hirsch88 added a commit that referenced this issue Apr 29, 2024
@github-actions @hirsch88
🐛 fix(toast): wrong position with angular 17 and build optimiser (#1390)
f30975e 
* Create PR for #1389

* define notice component inside the service

* format files

* fix ci

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirsch88 hirsch88

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix(toast): wrong position with angular 17 and build optimiser baloise/design-system
1 participant
@hirsch88