Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used github action for releases in our java template was marked as unmaintained #302

Closed
MarkusTiede opened this issue Jun 3, 2021 · 2 comments
Closed

Used github action for releases in our java template was marked as unmaintained #302

MarkusTiede opened this issue Jun 3, 2021 · 2 comments
Assignees
@MarkusTiede @arburk
Labels
help-wanted impediment If this is not done it blocks uplifting

Comments

@MarkusTiede
Copy link
Member

MarkusTiede commented Jun 3, 2021 •
edited
Loading

actions/create-release#119

affected: https://github.com/baloise/repository-template-java/blob/master/.github/workflows/release.yml
@MarkusTiede MarkusTiede changed the title Used github action for releases in our java template was marked as unmaintained: https://github.com/actions/create-release/issues/119 Used github action for releases in our java template was marked as unmaintained Jun 3, 2021
@MarkusTiede MarkusTiede added help-wanted impediment If this is not done it blocks uplifting labels Jun 3, 2021
@arburk
Copy link
Contributor

arburk commented Jun 13, 2021 •
edited by MarkusTiede
Loading

As far as I've read by now, a separate action for releases might by obsolete since GitHub cli is installed and available in actions. Thus the gh release create command can be used.

I've successfully tested this approach in private repo and adopted it here: https://github.com/baloise-incubator/codeql2sonar-maven-plugin/blob/main/.github/workflows/release.yml

  • review
  • decide if approach should be adopted

@arburk
Copy link
Contributor

arburk commented Jun 17, 2021

As decided in todays bi-weekly, we will adopt suggested approach

arburk added a commit to baloise/repository-template-java that referenced this issue Jun 17, 2021
@arburk
Replaced unmaintained create-release@v1 action by using Github CLI
c6ea096 
see: baloise/open-source#302
@arburk arburk mentioned this issue Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkusTiede MarkusTiede

@arburk arburk

Labels
help-wanted impediment If this is not done it blocks uplifting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkusTiede @arburk