Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix math in negative binomial example #835

Closed
tomicapretto opened this issue Aug 22, 2024 · 4 comments
Closed

Fix math in negative binomial example #835

tomicapretto opened this issue Aug 22, 2024 · 4 comments
Labels
documentation good first issue If you want to contribute but are not sure where to get started, this issue is for you!

Comments

@tomicapretto
Copy link
Collaborator

tomicapretto commented Aug 22, 2024

The following is not precise as it's not as the two things are not equal (the thing on the right is g(mu)).

image

https://bambinos.github.io/bambi/notebooks/negative_binomial.html

@tomicapretto tomicapretto added documentation good first issue If you want to contribute but are not sure where to get started, this issue is for you! labels Aug 22, 2024
@CodingWithError
Copy link

can you provide me some more details what are the changes you want in that.

@HarshvirSandhu
Copy link

Hi @tomicapretto
I would like to work on this issue

@tomicapretto
Copy link
Collaborator Author

Hi @CodingWithError @HarshvirSandhu, sorry for the lack of response.

The problem in that math is that it says the logarithm of the response variable (Y) is equal to the linear predictor. However, what's equal to the linear predictor is the logarithm of the expected value of Y.

$$ \log(\mathbb{E}(Y_i)) = \log(\mu_i) = \beta_1 \text{Academic}_i + \dots $$

@tanishy7777
Copy link
Contributor

Hey, I have made a PR for this issue. I hope it solves the problem. Please let me know if I need to add any more changes regarding this issue @tomicapretto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue If you want to contribute but are not sure where to get started, this issue is for you!
Projects
None yet
Development

No branches or pull requests

4 participants