Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #835 Updated notebooks/negative_binomial.html to correct the formula #859

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

tanishy7777
Copy link
Contributor

Updated notebooks/negative_binomial.html to correct the formula from log(Yi) = RHS to log(E(Yi) = RHS where RHS is a linear relationship of features.

Basically instead of
$\log \left( Y_i \right) = \log \left( \mu_i \right) = \beta_1 , \text{Academic}_i + \dots$

it should be

$\log \left( E(Y_i) \right) = \log \left( \mu_i \right) = \beta_1 , \text{Academic}_i + \dots$

Fix for Issue #835

  • Code passes tests
  • Code passes black
  • Code passes pylint

…, from log(Yi) = RHS to log(E(Yi) = RHS where RHS is a linear relationship of features.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tanishy7777
Copy link
Contributor Author

tanishy7777 commented Nov 28, 2024

I have attached the screenshot of the code passing black and pylint after making the changes

Pylint initially showed a score of 9.96/10 because I hadnt installed the 'jax' dependencies (only dev dependencies were installed)

image

image

@tomicapretto
Copy link
Collaborator

Thanks for the contribution @tanishy7777!

@tomicapretto tomicapretto merged commit bf73aff into bambinos:main Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants