Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formula class #585

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Add Formula class #585

merged 1 commit into from
Nov 5, 2022

Conversation

tomicapretto
Copy link
Collaborator

@tomicapretto tomicapretto commented Nov 5, 2022

This PR adds a new class called Formula. It closes #423. I have added tests. This class is not used within the Model class yet. That's going to come in a different PR.

@tomicapretto tomicapretto marked this pull request as ready for review November 5, 2022 16:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #585 (2116150) into main (c74fb3d) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   85.48%   85.72%   +0.23%     
==========================================
  Files          36       38       +2     
  Lines        2859     2914      +55     
==========================================
+ Hits         2444     2498      +54     
- Misses        415      416       +1     
Impacted Files Coverage Δ
bambi/formula.py 100.00% <100.00%> (ø)
bambi/tests/test_formula.py 100.00% <100.00%> (ø)
bambi/tests/test_built_models.py 96.08% <0.00%> (-0.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zwelitunyiswa
Copy link

This PR adds a new class called Formula. It closes #423. I have added tests. This class is not used within the Model class yet. That's going to come in a different PR.

Very cool! I have played with this in brms and it's incredibly powerful. Can I try it out on the dev branch of Bambi?

@canyon289
Copy link
Collaborator

❤️

@tomicapretto tomicapretto merged commit e05daf1 into bambinos:main Nov 5, 2022
@tomicapretto tomicapretto deleted the add_formula branch November 5, 2022 17:32
@tomicapretto
Copy link
Collaborator Author

This PR adds a new class called Formula. It closes #423. I have added tests. This class is not used within the Model class yet. That's going to come in a different PR.

Very cool! I have played with this in brms and it's incredibly powerful. Can I try it out on the dev branch of Bambi?

This is not going to have any effect in the meantime. I'm working in another branch to incorporate distributional models in Bambi. Stay tuned :)

@zwelitunyiswa
Copy link

Cool. Cheers, mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bambi formula object
4 participants